Skip to content

Update of Dilithium and Kyber aarch64 #543

Merged
thomwiggers merged 26 commits intoPQClean:masterfrom
vincentvbh:master
Feb 7, 2024
Merged

Update of Dilithium and Kyber aarch64 #543
thomwiggers merged 26 commits intoPQClean:masterfrom
vincentvbh:master

Conversation

@thomwiggers
Copy link
Copy Markdown
Member

@thomwiggers thomwiggers commented Jan 25, 2024

Continuation of PR #527 which I accidentally merged and then reverted (#542).

Dear all,

This pull request is an update of the aarch64 implementation of Dilithium and Kyber. Below are the summary of the changes.

(i) An improved version of NTT/iNTT exploiting the parallelism of arithmetic and memory ports (the idea was already applied to other simpler functions) (ii) br lr -> ret, this resolves open-quantum-safe/liboqs#1448. (iii) Constant declaration at proper .c files and remove unused constants (this resolves #516). (iv) Clarify the LICENSE file, this resolves #498. (v) Correct and extend the namespacing, the correction resolves #495.

Related issues that remain: #515. I need to look into this in the future.

Additionally, I have a question for PQClean: Can I assume that there will be something like fips202x2 for parallelized shake and sha3 on Armv8-A and skip the namespacing for this part? Currently, I skipped the namespacing for parallelized shake and sha3 since I assumed this.

Thanks, Vincent

See discussion in #527

@vincentvbh
Copy link
Copy Markdown
Contributor

vincentvbh commented Jan 26, 2024

I think this can be merged

@thomwiggers
Copy link
Copy Markdown
Member Author

thomwiggers commented Jan 26, 2024

Thanks Vincent. I'm on vacation until Monday 5/2, when I'm back I'll review.

@thomwiggers
Copy link
Copy Markdown
Member Author

thomwiggers commented Feb 5, 2024

I created a PR on your fork to add some allowances for namespacing of the shake2x API. Now, the following still need to be namespaced:

Missing namespace literal PQCLEAN_KYBER512_AARCH64_
	type: T, symbol: _asymmetric_const
	type: T, symbol: _constants
	type: T, symbol: _pre_asymmetric_table_Q1_extended
	type: T, symbol: _streamlined_CT_negacyclic_table_Q1_jump_extended
	type: T, symbol: _streamlined_inv_GS_negacyclic_table_Q1_jump_extended

@thomwiggers
Copy link
Copy Markdown
Member Author

thomwiggers commented Feb 5, 2024

And also

Missing namespace literal PQCLEAN_DILITHIUM5_AARCH64_
	type: T, symbol: _constants
	type: T, symbol: _streamlined_CT_negacyclic_table_Q1_jump_extended
	type: T, symbol: _streamlined_GS_itable_Q1_jump_extended

@thomwiggers
Copy link
Copy Markdown
Member Author

thomwiggers commented Feb 5, 2024

On my Mac, other tests now seem to pass.

@vincentvbh
Merge pull request #1 from PQClean/fix-vincent
c75c4e7 
Allow shake2x symbols to be not-namespaced
@thomwiggers thomwiggers merged commit ee71d2c into PQClean:master Feb 7, 2024
@thomwiggers
Copy link
Copy Markdown
Member Author

thomwiggers commented Feb 7, 2024

Thanks a lot @vincentvbh!

tniessen added a commit to tniessen/node-pqclean that referenced this pull request Feb 7, 2024
@tniessen
Update PQClean to ee71d2c
9b4f280 
Refs: PQClean/PQClean#504
Refs: PQClean/PQClean#512
Refs: PQClean/PQClean#519
Refs: PQClean/PQClean#521
Refs: PQClean/PQClean#527
Refs: PQClean/PQClean#534
Refs: PQClean/PQClean#535
Refs: PQClean/PQClean#536
Refs: PQClean/PQClean#540
Refs: PQClean/PQClean#541
Refs: PQClean/PQClean#542
Refs: PQClean/PQClean#543
data-wardenb6ym added a commit to data-wardenb6ym/node-pqclean that referenced this pull request Sep 29, 2025
@data-wardenb6ym
Update PQClean to ee71d2c
3693213 
Refs: PQClean/PQClean#504
Refs: PQClean/PQClean#512
Refs: PQClean/PQClean#519
Refs: PQClean/PQClean#521
Refs: PQClean/PQClean#527
Refs: PQClean/PQClean#534
Refs: PQClean/PQClean#535
Refs: PQClean/PQClean#536
Refs: PQClean/PQClean#540
Refs: PQClean/PQClean#541
Refs: PQClean/PQClean#542
Refs: PQClean/PQClean#543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@thomwiggers @vincentvbh