Add tests for variable-length signatures#541
Merged
thomwiggers merged 9 commits intomasterfrom Feb 5, 2024
Merged
Conversation
thomwiggers
requested changes
Jan 25, 2024
Member
thomwiggers
left a comment
There was a problem hiding this comment.
One minor suggestion for a change, and one discussion point.
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
| #include <string.h> | ||
| #include <valgrind/memcheck.h> |
Member
There was a problem hiding this comment.
Can we hide the Valgrind tests behind a #define? I think PQCLEAN_USE_VALGRIND or something along those lines sounds good.
Then we can pass this define in test_valgrind.py.
Collaborator
Author
There was a problem hiding this comment.
Done! Also rebased on the latest master, so hopefully CI will be green(er).
ef149dc to
5b10369
Compare
Closed
Member
|
I'm on vacation, so I'm afraid it'll be a little bit |
thomwiggers
approved these changes
Feb 5, 2024
tniessen
added a commit
to tniessen/node-pqclean
that referenced
this pull request
Feb 7, 2024
Refs: PQClean/PQClean#504 Refs: PQClean/PQClean#512 Refs: PQClean/PQClean#519 Refs: PQClean/PQClean#521 Refs: PQClean/PQClean#527 Refs: PQClean/PQClean#534 Refs: PQClean/PQClean#535 Refs: PQClean/PQClean#536 Refs: PQClean/PQClean#540 Refs: PQClean/PQClean#541 Refs: PQClean/PQClean#542 Refs: PQClean/PQClean#543
data-wardenb6ym
added a commit
to data-wardenb6ym/node-pqclean
that referenced
this pull request
Sep 29, 2025
Refs: PQClean/PQClean#504 Refs: PQClean/PQClean#512 Refs: PQClean/PQClean#519 Refs: PQClean/PQClean#521 Refs: PQClean/PQClean#527 Refs: PQClean/PQClean#534 Refs: PQClean/PQClean#535 Refs: PQClean/PQClean#536 Refs: PQClean/PQClean#540 Refs: PQClean/PQClean#541 Refs: PQClean/PQClean#542 Refs: PQClean/PQClean#543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for variable-length signatures, as discussed in #530.
There are two tests:
siglenis unmodified.The commit history contains a number of reverted commits which deliberately trigger test failures. This is to demonstrate that the new tests do indeed catch undesired behaviour. If you want to double-check this, just checkout one of the "TO BE REVERTED" commits and run either
pytest -v -n=auto -k "falcon-512 and clean" test_functest.py::test_functestorpytest -v -n=auto -k "falcon-512 and clean" test_valgrind.py. I'll squash these commits at merge.Will mark as ready for review once I see that CI has passed.