src/kem/kyber/.../*.S, src/sig/dilithium/.../*.S: Return using `ret'#1448
Closed
distorted-mdw wants to merge 1 commit intoopen-quantum-safe:mainfrom
Closed
src/kem/kyber/.../*.S, src/sig/dilithium/.../*.S: Return using `ret'#1448distorted-mdw wants to merge 1 commit intoopen-quantum-safe:mainfrom
distorted-mdw wants to merge 1 commit intoopen-quantum-safe:mainfrom
Conversation
Partly, `lr' isn't a register alias under older versions of GNU `as'. But, mostly, `br' doesn't mean the same thing to the branch predictor, so it will cause unnecessary misprediction stalls. Signed-off-by: Mark Wooding <mark.wooding@trustonic.com>
baentsch
reviewed
May 3, 2023
Member
baentsch
left a comment
There was a problem hiding this comment.
Just a comment regarding the placement of this PR: The code you are suggesting to change is automatically imported to liboqs from PQClean, so it would be more suitable to propose the code changes there instead of in this project.
|
This should be integrated into PQClean/PQClean#488 since the code base is the same. |
Contributor
Author
|
Yes. The reason I hadn't marked it for review is that I haven't yet prepared the MR for PQClean. |
Member
|
@distorted-mdw Do you still plan on doing a PR to PQClean for this? Our latest update from PQClean (#1512) didn't pull this in.... |
Member
|
Closing due to lack of feedback & stale-ness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly,
lrisn't a register alias under older versions of GNUas. But, mostly,brdoesn't mean the same thing to the branch predictor, so it will cause unnecessary misprediction stalls.