Skip to content

Licence for Dilithium and Kyber#488

Merged
dstebila merged 6 commits intoPQClean:masterfrom
vincentvbh:master
Jun 11, 2023
Merged

Licence for Dilithium and Kyber#488
dstebila merged 6 commits intoPQClean:masterfrom
vincentvbh:master

Conversation

@vincentvbh
Copy link
Copy Markdown
Contributor

As titled.
At the beginning of each file, you will find the license information.

Manually checked properties

  • Generated Github workflow (run .github/workflows/generate_workflows.py) (new schemes)
  • No stringification macros
  • Output-parameter pointers in functions are on the left
  • Negative return values on failure of API functions (within restrictions of FO transform).
  • variable declarations at the beginning (except in for (size_t i=...)
  • Optional:
    • All integer types are of fixed size, using stdint.h types (including uint8_t instead of unsigned char)
    • Integers used for indexing are of size size_t

@thomwiggers thomwiggers requested a review from mkannwischer May 2, 2023 18:08
@mkannwischer
Copy link
Copy Markdown
Contributor

Can we merge this or do we need to change it somehow? I would not know how to do it any better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants