Kyber for aarch64: incorrect Kyber768 and Kyber1024 implementation & symbol names mismatch #495
Description
The aarch64 implementations of Kyber768 and Kyber1024 seem to be incorrect and don't pass KAT tests.
The cause is in indcpa.c, which for all three Kyber variants appear to implement the same case for K=2:
https://github.com/PQClean/PQClean/blob/master/crypto_kem/kyber768/aarch64/indcpa.c
https://github.com/PQClean/PQClean/blob/master/crypto_kem/kyber1024/aarch64/indcpa.c
Another issue are symbol name mismatches between assembly code and C code, which causes linking to fail.
Example:
This is also an issue in the dilithium/aarch64 code:
The issues were noticed while integrating the latest pqclean code to liboqs (open-quantum-safe/liboqs#1512). The liboqs-PR contains a few temporary patches with fixes for them.