don't speak unless given text, ignore > and <#4706
Merged
Kebap merged 39 commits intodevelopmentfrom Feb 2, 2021
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Author
|
Works for me, please review. |
Contributor
|
Works good on Windows 10, and code logic looks sensible enough. |
atari2600tim
approved these changes
Jan 29, 2021
Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>
vadi2
approved these changes
Jan 29, 2021
Member
vadi2
left a comment
There was a problem hiding this comment.
Looks good, but I'd return nil+msg in case the text is autogenerated and someone wonders why isn't it doing anything
Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>
Contributor
Author
I was pondering that also. |
* Fixes problem blocking compilation of TMxpSendTagHandlerTest - Extracts TMediaData to a header in order to remove dependencies on MediaPlayer in testing environment * Adds override specifier to TMxpStubClient functions
Retitled from: "BugFix: correctly evaluate room m(in|ax)(x|y) values in all cases" We previously set them all to be 0.0 when there is no custom lines but technically, since they are supposed to be extremes of the room and it's custom exit lines they should be initialised to the room's own coordinates. Not doing this meant that in some cases they were being used but they did not hold sensible values. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Contributor
Author
|
Enhanced this scope to include #4689 as well. Need to review again. There is double code now, but did not refactor. |
This is an error that slipped in as a result of #4526 and resulted in the exit room id being stored as the special exit name in the BGL graph that is built for the A* search algorithm to work on. Consquently if that route was used in a path the special exit command produced for that step was garbage which also tripped off warnings about invalid characters being sent to the MUD as an exit direction. Thanks to @ryanstadther for bringing this to my attention! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This should close #4682. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…o tts_dont_speak
Contributor
Author
|
Oh no, I push/pulled in a wrong way, now many recent commits from development (?) are shown here as well.. |
…o tts_dont_speak
Contributor
Author
|
Those last 3 commits were the actual ones intended. |
vadi2
approved these changes
Feb 2, 2021
Contributor
|
fixes #3108 |
vadi2
added a commit
to vadi2/Mudlet
that referenced
this pull request
Feb 3, 2021
This reverts commit faad424.
vadi2
added a commit
that referenced
this pull request
Feb 3, 2021
Merged
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
…udlet#4738) This reverts commit faad424.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
only feed text to TTS engine when it contains more than whitespace, but remove > and < characters before
Motivation for adding to Mudlet
fix #4688
fix #4689
Other info (issues closed, discussion etc)
May be worthwile to raise this bug upsteam, but no idea how to build a minimal example without too much effort