Don't crash when closing Mudlet (PTBs only)#4723
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Jan 31, 2021
Merged
Conversation
This should close Mudlet#4682. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
Just checked. fixes issue. |
Delwing
approved these changes
Jan 31, 2021
Member
|
@zhenzh try memory profiling against this as well. We found another thing that wasn't being deleted when it should have been. |
vadi2
approved these changes
Jan 31, 2021
Member
|
Merging this one in to get rid of the crash! |
Member
Author
Not entirely true - it was being deleted - but a pointer that pointed at it was not - so when the container class tried to clean it up - it wasn't there to be cleaned up. Hence the crash. |
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
This should close Mudlet#4682. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #4682.
Signed-off-by: Stephen Lyons slysven@virginmedia.com