Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/1d0d1a/Mudlet-4.10.1-testing-pr4673-717b2069-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/6c80e8/Mudlet-4.10.1-testing-pr4673-717b2069.dmg
• windows: https://make.mudlet.org/snapshots/e6b49a/Mudlet-4.10.1-testing-pr4673-717b2069-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

If you were to reproduce it in ALL the items - would it be helpful to revise the placeholder text if the type QComboBox is set to a different type? This is so the text could reflect what is to go in the box - you can use the same slot-signal method as I previously used to copy a coloured icon from the QComboBox to that QLineEdit but which got removed...?

1. substring: Text to find
2. perl regex: Perl compatible regular expression
3. start of line: Text to find at the beginning of a line
4. exact match: Whole (all) line of text to find
5. lua function: Name of lua function returning true or false
6. line space: not applicable
7. color trigger: not applicable
8. prompt: not applicable

Also, for the substring case - as it is the default - you might need to also say - Text to find (this item ignored if left empty like this)

you can use the same slot-signal method as I previously used to copy a coloured icon from the QComboBox to that QLineEdit but which got removed...?

Which slot is that?

I like the suggestion.
Only some of the texts seem too complicated.
Also may need adjustment with the code placeholder text down below.

Which slot is that?

(void) dlgTriggerPatternEdit::slot_triggerTypeComboBoxChanged(const int) which got modified in #4531 as @Delwing also moved the coloured square that I had positioned to the left side within the QLineEdit that displayed the text (because I hadn't sorted out how to style the text via a built in Mudlet global style sheet to accommodate Light vs Dark DEs - on my TODO list...!) to a separate label which is filled with a icon with the corresponding colour.

Not sure how I like it, I think it loses sight of the original goal. See gif:

Code is pushed so you can try it for yourself.

Also given the space available it is possible for the line spacer one to actually say something about what the number means. Does a 0 valid mean an ignored line spacer trigger item - if so then QSpinBox::specialValueText could be useful...

Maybe try more similar texts like these examples:

substring: add your text to find - anywhere in the game output
perl regex: add your text to find - as a regular expression pattern
start of line: add your text to find - as the beginning of a line
exact match: add your text to find - as the whole text line

For "lua function" and "line spacer" I would not put any placeholder texts.

I was thinking that it would be applied to all the items - though as I said in that case the default (substring) one should also say something about leaving it empty means it is ignored. (Of course having all of them being so ignored is marked as an error for a non-trigger group TTriger instance).

I think it is pretty obvious that if it is empty, it does not do anything - spelling out that much detail doesn't make for a pretty result to look at.

Also given the space available it is possible for the line spacer one to actually say something about what the number means. Does a 0 valid mean an ignored line spacer trigger item - if so then QSpinBox::specialValueText could be useful...

Could be, but I'll leave that rabbithole for later 😅

Here's a fusion from the suggestions. Looks good now:

Getting better indeed.
Only doubt, you explain "exact match" with much the same words now. So not really. Also why drop the "text to find" pretext?

It didn't add much value and just made the placeholder longer, while we want to be short as possible, look at how nice this was: https://user-images.githubusercontent.com/110988/105627597-1b0dc980-5e38-11eb-9749-9a2630285444.png

Similar wording for exact match doesn't seem too bad because the placeholder is concise and straight to the point