Change line spacer trigger type to use spin box#4531
Change line spacer trigger type to use spin box#4531vadi2 merged 1 commit intoMudlet:developmentfrom
Conversation
move icon out of line edit action to make all types have small icon on the left
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
| regexList << pattern; | ||
|
|
||
| switch (mTriggerPatternEdit.at(i)->comboBox_patternType->currentIndex()) { | ||
| switch (patternType) { |
There was a problem hiding this comment.
Since you are using patternType directly here, it would make sense to use the same defines in the case XXX:s.
There was a problem hiding this comment.
Forgive me my lack of knowledge, but not sure what are you talking here about. I am actually not sure why this switch was there instead of just appending index directly to list.
There was a problem hiding this comment.
🤔 Ah, probably for code robustness - so that the index was not hard coded to the values defined in the REGEX_XXXX values (bit of a bad choice - TRIGGERTYPE_XXXX` would have been a better one IMVHO).
Yeah, in hindsight my suggestion isn't a change that should be made after all. I.e. ignore my previous comment... 🤦♂️
vadi2
left a comment
There was a problem hiding this comment.
Nice little piece of work, thanks for doing this!
move icon out of line edit action to make all types have small icon on the left Co-authored-by: Piotr Wilczynski <piotr.wilczynski@bisnode.com>
Brief overview of PR changes/additions
As mentioned in #4253 it would be puzzling to accept text values for trigger spacer.
Motivation for adding to Mudlet
Make input less puzzling for trigger spacer
Other info (issues closed, discussion etc)
closes #4253