Fixes problem blocking compilation of TMxpSendTagHandlerTest#4714
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Jan 30, 2021
Merged
Fixes problem blocking compilation of TMxpSendTagHandlerTest#4714vadi2 merged 2 commits intoMudlet:developmentfrom
vadi2 merged 2 commits intoMudlet:developmentfrom
Conversation
- Extracts TMediaData to a header in order to remove dependencies on MediaPlayer in testing environment
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Jan 29, 2021
Member
vadi2
left a comment
There was a problem hiding this comment.
The test works :)
There's a pair of warnings if you'd like to fix them:
Member
|
Thx! |
Contributor
|
Nice!!! Thank you @gcms ! |
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
…et#4714) * Fixes problem blocking compilation of TMxpSendTagHandlerTest - Extracts TMediaData to a header in order to remove dependencies on MediaPlayer in testing environment * Adds override specifier to TMxpStubClient functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fixes #4023
Motivation for adding to Mudlet
Reenable MXP send tags testing to support bug fixing
Other info (issues closed, discussion etc)