Fix Mudlet Discord link to always work#4697
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Jan 29, 2021
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
src/dlgAboutDialog.cpp
Outdated
| "<tr><td><span style=\"color:#bc8942;\"><b>Forums</b></span></td><td><a href=\"http://forums.mudlet.org/\">forums.mudlet.org</a></td></tr>\n" | ||
| "<tr><td><span style=\"color:#bc8942;\"><b>Documentation</b></span></td><td><a href=\"http://wiki.mudlet.org/w/Main_Page\">wiki.mudlet.org/w/Main_Page</a></td></tr>\n" | ||
| "<tr><td><span style=\"color:#7289DA;\"><b>Discord</b></span></td><td><a href=\"https://discord.gg/kuYvMQ9\">discord.gg</a></td></tr>\n" | ||
| "<tr><td><span style=\"color:#7289DA;\"><b>Discord</b></span></td><td><a href=\"https://www.mudlet.org/discord-invite\">discord.gg</a></td></tr>\n" |
Contributor
There was a problem hiding this comment.
Do you want the text in the about screen to say discord.gg still? All the rest are the same as the links.
Member
Author
There was a problem hiding this comment.
Yeah, I think so, since that's where it is heading.
atari2600tim
approved these changes
Jan 29, 2021
Member
Author
|
We can actually use this link to transfer to another platform later on if Discord kicks us off for some unfair reason. It's not unheard of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Create a permanent https://www.mudlet.org/discord-invite on mudlet.org which the app can always use. In the unlikely event of Discord breaking the link, we can always fix it on our side.
Motivation for adding to Mudlet
Fix #4696.
edit: Kebap: Also fix #3914
Other info (issues closed, discussion etc)
This enables for simpler code inside Mudlet so it's an overall better design.