Improve http error messages to make sense for the end player#4725
Improve http error messages to make sense for the end player#4725vadi2 merged 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Kebap
left a comment
There was a problem hiding this comment.
I understand the motivations behind a programmable error message, but it in practice it didn't work out
Me not so much. This seems better now.
SlySven
left a comment
There was a problem hiding this comment.
👎 Those texts weren't intended for direct display to the end user - as untranslated Lua API event texts they were supposed to be used to key responses from any event handler that got them - which of course will now have to be rewritten to check for the new texts you have just swapped them for. Fair enough error handling is something that has already become somewhat flexible in comparison with the do not break backwards compatibility mantra/dogma. For justification as to why the original texts were camelCaseRunTogetherWords it is just an extension of the same process that is used to give the events identifiers - they are of the same form.
I do not see directly how the event arguments are translated into "http error messages" but perhaps the changes should have been made elsewhere where the event arguments were turned into a [ WARN ] - type message on screen - which is supposed to be translated...
😠
|
I don't think any scripts are using those messages to be honest, that's why I feel this is a safe change to make. I don't think you'll find scripts that actually read those arguments. |
Brief overview of PR changes/additions
Improve http error messages to make sense for the end player
Motivation for adding to Mudlet
So coders can use the error message as-is without having to worry to translate it to something the player would understand.
Other info (issues closed, discussion etc)
The first time I've seen someone use them - and it was someone experienced with Mudlet, @Delwing, the end result didn't work out:
I don't think the expectations that the interface is simple to use were met by Mudlet here. I understand the motivations behind a programmable error message, but it in practice it didn't work out, and it's better to be consistent with all the other messages we use which are player-friendly.