Skip to content

Fix import/order issues#9239

Merged
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:enable-import/order
Aug 18, 2020
Merged

Fix import/order issues#9239
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:enable-import/order

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

Refs #8982

See import/order for more information.

This change enables import/order and fixes the issues raised by the rule.

@whymarrh whymarrh changed the title Enable import/order Fix import/order issues Aug 14, 2020
@whymarrh
Copy link
Copy Markdown
Contributor Author

Based on #9233

@whymarrh whymarrh force-pushed the enable-import/order branch 3 times, most recently from 1d7a3b8 to ccac777 Compare August 18, 2020 15:05
@whymarrh whymarrh marked this pull request as ready for review August 18, 2020 16:37
@whymarrh whymarrh requested review from a team and kumavis as code owners August 18, 2020 16:37
@whymarrh whymarrh requested a review from danjm August 18, 2020 16:37
@whymarrh whymarrh force-pushed the enable-import/order branch from ccac777 to 2a5ef51 Compare August 18, 2020 16:42
See [`import/order`](https://eslint.org/docs/rules/import/order) for more information.

This change enables `import/order` and fixes the issues raised by the rule.
@whymarrh whymarrh force-pushed the enable-import/order branch from 2a5ef51 to fa7cb9a Compare August 18, 2020 18:55
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whymarrh whymarrh merged commit c1e3c22 into MetaMask:develop Aug 18, 2020
@whymarrh whymarrh deleted the enable-import/order branch August 18, 2020 19:18
Gudahtt added a commit that referenced this pull request Aug 19, 2020
* origin/develop: (137 commits)
  Use @metamask/eslint-config@3.1.0 (#9275)
  Standardize scss import practices (#9183)
  Update ESLint shared config to v3 (#9274)
  Add lock icon to default networks (#9269)
  Adds toPrecisionWithoutTrailingZeros utility (#9270)
  Hide gas estimate on non-main network (#9189)
  Move the mascot component to its own directory (#9272)
  Use @metamask/controllers@2.0.5 (#9266)
  Fix padding, alignment of actionable-message; add left aligned story
  Code cleanup and simplification for actionable-message component
  Adds actionable message component and stories
  Fix lint issues (#9265)
  Fix prefer-destructuring issues (#9263)
  colocate confirm-decrypt-message page styles (#9252)
  Tidy up Migrator tests (#9264)
  Adds pulse loader component (#9259)
  Fix import/order issues (#9239)
  Fix radix issues (#9247)
  New info tooltip component (#9180)
  Improve scss naming
  ...
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2025
#30661)

## **Description**

@davidmurdoch requested this feature here:
#30440 (review)

Also adds to the VSCode GitLens settings. If a Cursor user could help
with the Cursor settings, that would be much appreciated.

We should discuss:

- The inclusion of #17092, as I'm undecided about it
- Whether it's appropriate to automatically execute `git config
blame.ignoreRevsFile .git-blame-ignore-revs` in `postinstall`. It writes
to the local `.git/config` file in your `metamask-extension` folder, so
it's only changing that one folder.

Command to get commits with over 200 file changes
```
git log --pretty=format:"%H %s" --shortstat | awk '{if ($1 ~ /^[0-9]+$/) {num = $1 + 0; if (num > 200 && current_hash !~ /Revert/) print num " " current_hash} else current_hash = $0}' | sort -nr
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30661?quickstart=1)

## **Related issues**

David Murdoch request:
#30440 (review)

## **Ignored PRs**

- #6304 
- #7730 
- #8023 
- #8056 
- #8595 
- #9239 
- #9274 
- #10358
- #10655
- #10911
- #17092
- #22639
- #22531
- #30440

<!--## **Manual testing steps**
## **Screenshots/Recordings**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->

---------

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants