Add lock icon to default networks#9269
Merged
brad-decker merged 1 commit intoMetaMask:developfrom Aug 19, 2020
Merged
Conversation
Contributor
|
Code looks good. I checked out the branch and UI looks good:
|
Contributor
|
One slight UX improve might be to hide the "Cancel" and "Save" buttons entirely for these networks that get the lock symbol. But I won't block over that possible improvement. |
danjm
approved these changes
Aug 19, 2020
brad-decker
approved these changes
Aug 19, 2020
Gudahtt
added a commit
that referenced
this pull request
Aug 19, 2020
* origin/develop: (137 commits) Use @metamask/eslint-config@3.1.0 (#9275) Standardize scss import practices (#9183) Update ESLint shared config to v3 (#9274) Add lock icon to default networks (#9269) Adds toPrecisionWithoutTrailingZeros utility (#9270) Hide gas estimate on non-main network (#9189) Move the mascot component to its own directory (#9272) Use @metamask/controllers@2.0.5 (#9266) Fix padding, alignment of actionable-message; add left aligned story Code cleanup and simplification for actionable-message component Adds actionable message component and stories Fix lint issues (#9265) Fix prefer-destructuring issues (#9263) colocate confirm-decrypt-message page styles (#9252) Tidy up Migrator tests (#9264) Adds pulse loader component (#9259) Fix import/order issues (#9239) Fix radix issues (#9247) New info tooltip component (#9180) Improve scss naming ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds lock icon next to default networks in networks list in settings. It was not clear that these networks cannot be edited nor deleted. It makes it easier to differentiate them from custom rpc networks.
Addresses the issues brought up in #8566
Screenshot 2020-08-19 at 08.53.17