Skip to content

Tidy up Migrator tests#9264

Merged
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:tidy-Migrator-tests
Aug 18, 2020
Merged

Tidy up Migrator tests#9264
whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh:tidy-Migrator-tests

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

This PR tidies up the Migrator tests, sorting the imports and fixing no-shadow issues

@whymarrh whymarrh requested a review from a team as a code owner August 18, 2020 18:21
@whymarrh whymarrh requested a review from Gudahtt August 18, 2020 18:21
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 6f4c3b3 into MetaMask:develop Aug 18, 2020
@whymarrh whymarrh deleted the tidy-Migrator-tests branch August 18, 2020 19:24
Gudahtt added a commit that referenced this pull request Aug 19, 2020
* origin/develop: (137 commits)
  Use @metamask/eslint-config@3.1.0 (#9275)
  Standardize scss import practices (#9183)
  Update ESLint shared config to v3 (#9274)
  Add lock icon to default networks (#9269)
  Adds toPrecisionWithoutTrailingZeros utility (#9270)
  Hide gas estimate on non-main network (#9189)
  Move the mascot component to its own directory (#9272)
  Use @metamask/controllers@2.0.5 (#9266)
  Fix padding, alignment of actionable-message; add left aligned story
  Code cleanup and simplification for actionable-message component
  Adds actionable message component and stories
  Fix lint issues (#9265)
  Fix prefer-destructuring issues (#9263)
  colocate confirm-decrypt-message page styles (#9252)
  Tidy up Migrator tests (#9264)
  Adds pulse loader component (#9259)
  Fix import/order issues (#9239)
  Fix radix issues (#9247)
  New info tooltip component (#9180)
  Improve scss naming
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants