Conversation
|
I thought we were trying to deprecate this tooltip? |
|
@Gudahtt Okay, I will update to use the v2 one. Meanwhile we should put comments in |
|
Just mocked up these specs, can we have the text left-aligned and match this spacing / font color?
|
|
@Gudahtt updated to use tooltip-v2 @jakehaugen updates were also made to match your image above. Updated gif:
|
Builds ready [5c4dabf]
Page Load Metrics (583 ± 41 ms)
|
Builds ready [c3f6ece]
Page Load Metrics (591 ± 11 ms)
|
|
@danjm work just landed that removes the old tooltip and renamed tooltip-v2 to tooltip. If you consume the component from the 'tooltip' folder it'll be the newest, sanctioned tooltip component. I hope that was English, I feel like I typed tooltip way too many times. |
There was a problem hiding this comment.
| import Tooltip from '../tooltip-v2' | |
| import Tooltip from '../tooltip' |
ui/app/components/ui/tooltip-v2.js
Outdated
There was a problem hiding this comment.
You'll need to carry these changes over to components/ui/tooltip/tooltip
|
@brad-decker I have rebased and updated this to reflect the latest changes on develop (as per your comments) |
Builds ready [f18fcaa]
Page Load Metrics (609 ± 87 ms)
|
* origin/develop: (137 commits) Use @metamask/eslint-config@3.1.0 (#9275) Standardize scss import practices (#9183) Update ESLint shared config to v3 (#9274) Add lock icon to default networks (#9269) Adds toPrecisionWithoutTrailingZeros utility (#9270) Hide gas estimate on non-main network (#9189) Move the mascot component to its own directory (#9272) Use @metamask/controllers@2.0.5 (#9266) Fix padding, alignment of actionable-message; add left aligned story Code cleanup and simplification for actionable-message component Adds actionable message component and stories Fix lint issues (#9265) Fix prefer-destructuring issues (#9263) colocate confirm-decrypt-message page styles (#9252) Tidy up Migrator tests (#9264) Adds pulse loader component (#9259) Fix import/order issues (#9239) Fix radix issues (#9247) New info tooltip component (#9180) Improve scss naming ...
This PR adds a component that is an info icon with a tooltip. It can be used in places where we need to give the user information.
Demo gif:
The gif is from the implementation in storybook, which can be seen by checking out the branch and running
yarn storybook