style: apply Prettier to md, mdx, and yml files by HowardBraham · Pull Request #30440 · MetaMask/metamask-extension

HowardBraham · 2025-02-19T19:07:53Z

Description

Previously, we were running Prettier on .json files, but not on .md, .mdx, and .yml files.

There are many changed files, but only 4 real changes made in this PR:

Modify package.json to run Prettier on **/*.{json,md,mdx,yml}
added CHANGELOG.md to .prettierignore
@georgewrmarshall removed an old comment that was breaking the Storybook build
Run yarn lint:prettier:fix

Manual testing steps

Please look for mistakes Prettier may have made, especially in md and mdx files.
You may want to use the "Hide whitespace" toggle in GitHub, and you may want to look at the "rich diff."
~~We will have to rewrite the files to be Prettier-stable.~~ ✔️ Done
~~I see a few mistakes myself and will mark them.~~ ✔️ Done

github-actions · 2025-02-19T19:08:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/pages/unlock-page/README.mdx

CHANGELOG.md

HowardBraham · 2025-02-19T19:45:28Z

docs/lavamoat-policy-review-process.md

+3.  To generate a complete set of new policies, call `metamaskbot` for help:
+    - put `@metamaskbot update-policies` in a comment on the PR. When it produces changes, they need to be reviewed. The following steps assume update-policies produced changes.
+    - _Note the response from the bot points to instructions on how to review the policy for your convenience. https://lavamoat.github.io/guides/policy-diff/_
+4.  Analyze the diff of policy.json and use the understanding of the codebase and change being made to decide whether the capabilities added make sense in that context. Leave a comment listing any doubts you have with brief explanations or if everything is in order, then say so and explain why the most powerful capabilities are there (like access to `child_process.exec` in node or network access in the browser)


I slightly changed the text here to make it Prettier-stable

metamaskbot · 2025-02-20T23:34:54Z

Builds ready [eca7e33]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1803 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	244	2179	1734	377	181
		domContentLoaded	1547	2116	1780	157	75
		load	1586	2179	1803	158	76
		domInteractive	27	168	51	32	15
		backgroundConnect	9	99	30	25	12
		firstReactRender	15	89	46	25	12
		getState	5	92	24	25	12
		initialActions	0	1	0	0	0
		loadScripts	1093	1632	1315	143	69
		setupStore	8	75	24	23	11
		uiStartup	1837	2585	2108	199	96

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

davidmurdoch

Cool.

Can we follow this commit up with a PR that adds the commit hash (and a comment explain what the commit is) to .git-blame-ignore-revs (I think it is already the default )? Git docs: https://git-scm.com/docs/git-blame#Documentation/git-blame.txt-blameignoreRevsFile

metamaskbot · 2025-02-26T21:30:55Z

Builds ready [3736c51]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1656 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1387	1972	1659	141	68
		domContentLoaded	1379	1909	1626	128	61
		load	1387	1922	1656	137	66
		domInteractive	24	73	37	16	7
		backgroundConnect	10	83	33	23	11
		firstReactRender	14	63	22	14	7
		getState	4	59	17	19	9
		initialActions	0	1	0	0	0
		loadScripts	1011	1430	1217	108	52
		setupStore	7	59	13	13	6
		uiStartup	1590	2207	1873	158	76

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-27T01:17:17Z

Builds ready [7c06975]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1738 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	349	2022	1672	329	158
		domContentLoaded	1502	1904	1711	112	54
		load	1541	2003	1738	123	59
		domInteractive	26	100	39	20	10
		backgroundConnect	11	93	33	21	10
		firstReactRender	15	74	35	23	11
		getState	5	54	14	14	7
		initialActions	0	1	0	0	0
		loadScripts	1094	1433	1263	101	48
		setupStore	7	68	19	19	9
		uiStartup	1744	2382	1994	152	73

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot added the team-tiger-deprecated DEPRECATED: team no longer exists label Feb 19, 2025

HowardBraham added team-extension-platform Extension Platform team and removed team-tiger-deprecated DEPRECATED: team no longer exists labels Feb 19, 2025

HowardBraham force-pushed the prettier-yml branch from 37501a2 to 24c21c6 Compare February 19, 2025 19:44

HowardBraham commented Feb 19, 2025

View reviewed changes

HowardBraham marked this pull request as ready for review February 19, 2025 19:47

HowardBraham requested review from a team as code owners February 19, 2025 19:47

HowardBraham force-pushed the prettier-yml branch from 378cdd4 to eca7e33 Compare February 20, 2025 22:59

HowardBraham requested review from darkwing, georgewrmarshall and vinnyhoward February 21, 2025 00:04

HowardBraham self-assigned this Feb 21, 2025

HowardBraham requested a review from seaona February 21, 2025 00:05

davidmurdoch previously approved these changes Feb 21, 2025

View reviewed changes

vinnyhoward previously approved these changes Feb 24, 2025

View reviewed changes

georgewrmarshall previously approved these changes Feb 24, 2025

View reviewed changes

HowardBraham requested review from ghgoodreau and micaelae February 24, 2025 20:51

OGPoyraz previously approved these changes Feb 26, 2025

View reviewed changes

HowardBraham enabled auto-merge February 26, 2025 09:30

itsyoboieltr previously approved these changes Feb 26, 2025

View reviewed changes

amitabh94 previously approved these changes Feb 26, 2025

View reviewed changes

HowardBraham added this pull request to the merge queue Feb 26, 2025

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Feb 26, 2025

HowardBraham requested review from GustavoRSSilva, amitabh94, georgewrmarshall and vinnyhoward February 26, 2025 20:56

georgewrmarshall approved these changes Feb 26, 2025

View reviewed changes

davidmurdoch approved these changes Feb 26, 2025

View reviewed changes

OGPoyraz approved these changes Feb 26, 2025

View reviewed changes

HowardBraham enabled auto-merge February 26, 2025 21:15

darkwing approved these changes Feb 26, 2025

View reviewed changes

amitabh94 approved these changes Feb 26, 2025

View reviewed changes

HowardBraham added this pull request to the merge queue Feb 26, 2025

GustavoRSSilva approved these changes Feb 26, 2025

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025

HowardBraham force-pushed the prettier-yml branch from 3736c51 to f6a39e8 Compare February 26, 2025 22:18

vinnyhoward approved these changes Feb 26, 2025

View reviewed changes

HowardBraham enabled auto-merge February 27, 2025 00:38

HowardBraham and others added 5 commits February 26, 2025 16:38

style: apply Prettier to md, mdx, and yml files

54e7eac

changed files to make them Prettier-stable

86bfd90

chore: removing broken args table from unlock page mdx

20bcd35

added CHANGELOG.md to .prettierignore

36be6e0

fixed merge conflict in README.md

7c06975

HowardBraham force-pushed the prettier-yml branch from f6a39e8 to 7c06975 Compare February 27, 2025 00:38

HowardBraham added this pull request to the merge queue Feb 27, 2025

Merged via the queue into main with commit dc73251 Feb 27, 2025
79 checks passed

HowardBraham deleted the prettier-yml branch February 27, 2025 01:45

github-actions bot locked and limited conversation to collaborators Feb 27, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style: apply Prettier to md, mdx, and yml files#30440

style: apply Prettier to md, mdx, and yml files#30440
HowardBraham merged 5 commits intomainfrom
prettier-yml

HowardBraham commented Feb 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Uh oh!

Uh oh!

HowardBraham Feb 19, 2025

Uh oh!

metamaskbot commented Feb 20, 2025

Uh oh!

davidmurdoch left a comment

Uh oh!

metamaskbot commented Feb 26, 2025

Uh oh!

Uh oh!

metamaskbot commented Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

HowardBraham commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual testing steps

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Uh oh!

Uh oh!

HowardBraham Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Feb 20, 2025

Uh oh!

davidmurdoch left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Feb 26, 2025

Uh oh!

Uh oh!

metamaskbot commented Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

HowardBraham commented Feb 19, 2025 •

edited

Loading