Skip to content

feat: extend isAtomicBatchSupported result#5600

Merged
matthewwalsh0 merged 4 commits intomainfrom
feat/is-atomic-batch-supported
Apr 8, 2025
Merged

feat: extend isAtomicBatchSupported result#5600
matthewwalsh0 merged 4 commits intomainfrom
feat/is-atomic-batch-supported

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Apr 6, 2025

Explanation

Return additional data from isAtomicBatchSupported method, including:

  • delegationAddress
  • isSupproted
  • upgradeContractAddress

Support optionally filtering chains with chainIds option.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review April 6, 2025 21:30
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners April 6, 2025 21:30
@matthewwalsh0
Copy link
Copy Markdown
Member Author

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-88ffa32",
  "@metamask-previews/address-book-controller": "6.0.3-preview-88ffa32",
  "@metamask-previews/announcement-controller": "7.0.3-preview-88ffa32",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-88ffa32",
  "@metamask-previews/approval-controller": "7.1.3-preview-88ffa32",
  "@metamask-previews/assets-controllers": "56.0.0-preview-88ffa32",
  "@metamask-previews/base-controller": "8.0.0-preview-88ffa32",
  "@metamask-previews/bridge-controller": "12.0.0-preview-88ffa32",
  "@metamask-previews/bridge-status-controller": "11.0.0-preview-88ffa32",
  "@metamask-previews/build-utils": "3.0.3-preview-88ffa32",
  "@metamask-previews/chain-agnostic-permission": "0.3.0-preview-88ffa32",
  "@metamask-previews/composable-controller": "11.0.0-preview-88ffa32",
  "@metamask-previews/controller-utils": "11.7.0-preview-88ffa32",
  "@metamask-previews/earn-controller": "0.10.0-preview-88ffa32",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-88ffa32",
  "@metamask-previews/ens-controller": "16.0.0-preview-88ffa32",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-88ffa32",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-88ffa32",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-88ffa32",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-88ffa32",
  "@metamask-previews/keyring-controller": "21.0.1-preview-88ffa32",
  "@metamask-previews/logging-controller": "6.0.4-preview-88ffa32",
  "@metamask-previews/message-manager": "12.0.1-preview-88ffa32",
  "@metamask-previews/multichain": "4.0.0-preview-88ffa32",
  "@metamask-previews/multichain-api-middleware": "0.1.1-preview-88ffa32",
  "@metamask-previews/multichain-network-controller": "0.3.0-preview-88ffa32",
  "@metamask-previews/multichain-transactions-controller": "0.8.0-preview-88ffa32",
  "@metamask-previews/name-controller": "8.0.3-preview-88ffa32",
  "@metamask-previews/network-controller": "23.2.0-preview-88ffa32",
  "@metamask-previews/notification-services-controller": "5.0.1-preview-88ffa32",
  "@metamask-previews/permission-controller": "11.0.6-preview-88ffa32",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-88ffa32",
  "@metamask-previews/phishing-controller": "12.4.1-preview-88ffa32",
  "@metamask-previews/polling-controller": "13.0.0-preview-88ffa32",
  "@metamask-previews/preferences-controller": "17.0.0-preview-88ffa32",
  "@metamask-previews/profile-sync-controller": "11.0.0-preview-88ffa32",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-88ffa32",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-88ffa32",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-88ffa32",
  "@metamask-previews/sample-controllers": "0.1.0-preview-88ffa32",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-88ffa32",
  "@metamask-previews/signature-controller": "27.1.0-preview-88ffa32",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-88ffa32",
  "@metamask-previews/transaction-controller": "53.0.0-preview-88ffa32",
  "@metamask-previews/user-operation-controller": "32.0.0-preview-88ffa32"
}

@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) April 8, 2025 10:53
@matthewwalsh0 matthewwalsh0 force-pushed the feat/is-atomic-batch-supported branch from 88ffa32 to 6a29cee Compare April 8, 2025 10:53
@matthewwalsh0 matthewwalsh0 merged commit 47936ab into main Apr 8, 2025
197 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/is-atomic-batch-supported branch April 8, 2025 10:58
matallui added a commit that referenced this pull request Apr 9, 2025
* main:
  Fix unmocked block tracker warning in NetworkController tests (#5289)
  ci: GH action to remind developers to add release notes in CHANGELOG.md (#5620)
  Release 355.0.0 (#5619)
  Release 354.0.0 (#5615)
  fix: Update origin in Snap requests (#5616)
  Release/353.0.0 (#5612)
  refactor(accounts-controller): use type-cast instead of `@ts-expect-error` (#5568)
  feat: support external sign transactions (#5604)
  feat: extend isAtomicBatchSupported result (#5600)
  fix: Rename `enableTxParamsGasFeeUpdates` to `isAutomaticGasFeeUpdateEnabled` and also callback (#5602)
  Release/352.0.0 (#5608)
  feat: STAKE-1005: refresh staking data when staking txs are confirmed (#5607)
matthewwalsh0 added a commit that referenced this pull request Apr 16, 2025
Return additional data from `isAtomicBatchSupported` method, including:

- `delegationAddress`
- `isSupproted`
- `upgradeContractAddress`

Support optionally filtering chains with `chainIds` option.

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
dbrans pushed a commit to MetaMask/metamask-extension that referenced this pull request Apr 16, 2025
## **Description**

Cherry-pick of #31913 for `12.16.1`.

Creating manual PR as patch required for
`@metamask/transaction-controller`.

Patch changes are cherry-picks of
[#5600](MetaMask/core#5600),
[#5635](MetaMask/core#5635), and
[#5637](MetaMask/core#5637), built from
[patch/transaction-controller-extension-12-16-1](MetaMask/core@patch/transaction-controller-extension-12-16-0...patch/transaction-controller-extension-12-16-1).

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32023?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
matthewwalsh0 added a commit to MetaMask/metamask-extension that referenced this pull request Apr 21, 2025
Cherry-pick of #31913 for `12.16.1`.

Creating manual PR as patch required for
`@metamask/transaction-controller`.

Patch changes are cherry-picks of
[#5600](MetaMask/core#5600),
[#5635](MetaMask/core#5635), and
[#5637](MetaMask/core#5637), built from
[patch/transaction-controller-extension-12-16-1](MetaMask/core@patch/transaction-controller-extension-12-16-0...patch/transaction-controller-extension-12-16-1).

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32023?quickstart=1)

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants