feat: support version 2.0.0 of EIP-5792 by matthewwalsh0 · Pull Request #31913 · MetaMask/metamask-extension

matthewwalsh0 · 2025-04-11T23:46:08Z

Description

Update middleware handlers to support version 2.0.0 of EIP-5792.

Specifically:

Update supported wallet_sendCalls version to 2.0.0.
Return atomic capability in wallet_getCapabilities including status property.
Fallback to AccountsController:getSelectedAccount if from not specified in wallet_sendCalls.
Use new error codes.
Bump @metamask/eth-json-rpc-middleware, @metamask/transaction-controller, and @metamask/test-dapp.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-04-14T09:41:37Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/transaction-controller@54.0.0 ⏵ 54.1.0	⁺¹		⁺¹
	@metamask/test-dapp@9.2.0 ⏵ 9.3.0	⁺⁸

View full report

metamaskbot · 2025-04-14T09:42:15Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/hooks/useSmartAccountActions.ts

🧩 @MetaMask/extension-devs

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

📜 @MetaMask/policy-reviewers

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

🔗 @MetaMask/supply-chain

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

metamaskbot · 2025-04-15T19:58:29Z

Builds ready [2e87ac0]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 53 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1126	1368	53	1259	1323
			load	1057	964	1224	52	1087	1151
			domContentLoaded	1051	958	1218	52	1082	1147
			domInteractive	18	13	63	8	17	33
			firstPaint	695	76	1177	418	1078	1138
			backgroundConnect	6	4	18	2	7	9
			firstReactRender	20	15	46	4	21	26
			getState	13	4	30	7	18	28
			initialActions	0	0	1	0	0	1
			loadScripts	810	718	949	50	835	891
			setupStore	8	5	17	2	8	11
	Webpack	Home	uiStartup	2115	1684	2503	165	2208	2390
			load	1630	1301	2216	140	1725	1810
			domContentLoaded	1620	1297	1953	130	1718	1807
			domInteractive	15	11	63	10	13	44
			firstPaint	177	69	326	52	213	289
			backgroundConnect	27	9	319	32	29	55
			firstReactRender	207	54	382	121	337	359
			getState	11	3	52	8	13	25
			initialActions	3	1	6	1	3	5
			loadScripts	1616	1296	1931	130	1716	1805
			setupStore	24	6	303	43	20	35
Firefox	Browserify	Home	uiStartup	1427	1195	1861	132	1491	1674
			load	1264	1053	1672	134	1335	1528
			domContentLoaded	1264	1053	1671	134	1335	1527
			domInteractive	106	37	257	33	125	164
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	110	15	23	66
			firstReactRender	24	20	52	4	25	31
			getState	8	5	38	4	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1242	1027	1649	136	1313	1509
			setupStore	9	4	192	19	7	13
	Webpack	Home	uiStartup	1476	1335	1809	112	1532	1734
			load	1262	1141	1572	102	1305	1479
			domContentLoaded	1261	1141	1572	102	1305	1478
			domInteractive	79	34	291	29	82	132
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	79	10	22	40
			firstReactRender	35	29	52	5	37	44
			getState	9	4	33	6	9	28
			initialActions	0	0	2	1	1	1
			loadScripts	1243	1122	1558	103	1288	1464
			setupStore	9	5	40	6	8	28

metamaskbot · 2025-04-15T21:16:36Z

Builds ready [2e87ac0]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1227 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1227	1106	1390	64	1272	1338
			load	1054	916	1217	59	1086	1163
			domContentLoaded	1048	905	1212	58	1078	1157
			domInteractive	18	13	73	8	17	28
			firstPaint	770	85	1220	410	1069	1164
			backgroundConnect	6	4	24	2	7	8
			firstReactRender	21	16	45	5	21	34
			getState	13	5	38	8	18	33
			initialActions	0	0	1	0	0	1
			loadScripts	809	666	980	57	841	910
			setupStore	8	5	19	2	9	12
	Webpack	Home	uiStartup	2136	1749	2602	180	2251	2405
			load	1645	1348	2053	139	1753	1868
			domContentLoaded	1639	1345	2043	137	1746	1861
			domInteractive	15	11	64	10	13	45
			firstPaint	177	66	346	56	217	282
			backgroundConnect	25	10	68	13	30	55
			firstReactRender	222	57	402	116	337	360
			getState	12	4	49	7	14	26
			initialActions	3	1	8	1	4	6
			loadScripts	1634	1343	2019	136	1744	1851
			setupStore	21	6	312	31	23	38
Firefox	Browserify	Home	uiStartup	1434	1250	1909	124	1485	1693
			load	1269	1058	1725	125	1336	1519
			domContentLoaded	1269	1058	1725	125	1335	1519
			domInteractive	103	38	177	28	122	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	13	142	21	25	86
			firstReactRender	24	20	40	3	26	32
			getState	8	4	25	3	9	11
			initialActions	0	0	1	0	0	1
			loadScripts	1245	1044	1707	122	1320	1468
			setupStore	8	4	199	19	7	10
	Webpack	Home	uiStartup	1518	1383	2000	134	1549	1807
			load	1296	1172	1730	116	1317	1519
			domContentLoaded	1295	1172	1729	116	1317	1519
			domInteractive	85	53	337	34	94	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	44	7	24	42
			firstReactRender	35	28	51	5	37	46
			getState	9	4	31	4	9	20
			initialActions	1	0	2	1	1	1
			loadScripts	1275	1150	1710	116	1301	1502
			setupStore	12	6	288	28	8	26

Update version.

metamaskbot · 2025-04-15T23:36:46Z

Builds ready [c37b9a2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1211	1090	1395	57	1247	1318
			load	1048	951	1226	54	1083	1161
			domContentLoaded	1043	946	1220	54	1078	1153
			domInteractive	17	13	62	7	17	30
			firstPaint	702	134	1234	420	1067	1126
			backgroundConnect	6	4	18	2	7	9
			firstReactRender	22	16	64	8	21	42
			getState	13	5	35	8	18	30
			initialActions	0	0	1	0	0	1
			loadScripts	802	711	973	51	833	898
			setupStore	7	4	21	3	8	11
	Webpack	Home	uiStartup	2101	1747	2526	176	2195	2372
			load	1618	1356	1957	129	1717	1817
			domContentLoaded	1611	1353	1926	128	1713	1809
			domInteractive	16	11	67	11	13	43
			firstPaint	184	65	356	69	232	327
			backgroundConnect	24	9	78	14	25	59
			firstReactRender	198	54	395	122	336	361
			getState	11	4	47	6	14	21
			initialActions	3	1	10	1	3	5
			loadScripts	1606	1351	1902	127	1705	1806
			setupStore	35	6	301	67	20	256
Firefox	Browserify	Home	uiStartup	1332	1141	1772	118	1391	1595
			load	1188	998	1611	125	1239	1445
			domContentLoaded	1187	998	1611	125	1239	1445
			domInteractive	100	42	224	28	109	158
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	108	11	19	37
			firstReactRender	22	19	54	4	22	27
			getState	7	4	32	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1170	984	1567	125	1225	1431
			setupStore	6	4	34	5	6	10
	Webpack	Home	uiStartup	1549	1367	2158	145	1609	1856
			load	1319	1150	1914	136	1383	1616
			domContentLoaded	1319	1150	1914	136	1382	1616
			domInteractive	81	57	141	19	95	119
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	93	11	22	40
			firstReactRender	36	29	64	5	38	47
			getState	9	4	31	7	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1300	1132	1894	135	1359	1598
			setupStore	11	5	314	31	8	16

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 102.23 KiB (1.98%)
ui: 117 Bytes (0%)
common: 3.89 KiB (0.04%)

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Apr 11, 2025

matthewwalsh0 requested a review from a team as a code owner April 11, 2025 23:46

matthewwalsh0 requested review from a team as code owners April 15, 2025 19:08

matthewwalsh0 added 13 commits April 15, 2025 23:22

Initial draft

b0ca21d

Add unit tests

1930dc0

Update version.

Add unit tests

ff4272f

Normalize input chain IDs

ce28ac0

Add hook

5c8fdaf

Add error codes

702cdae

Update splash reject error code

c2d8d31

Update version

95837c8

Update packages

23b24fa

Fix linting

54a1071

Use new versions

d546ed1

Update test dApp

a2b18a6

Update policies

9804cab

matthewwalsh0 force-pushed the feat/eip-5792-atomic-capability branch from 2e87ac0 to 9804cab Compare April 15, 2025 22:22

Fix E2E tests

c37b9a2

matthewwalsh0 added a commit that referenced this pull request Apr 15, 2025

feat: support version 2.0.0 of EIP-5792 (#31913)

a3b7d1e

matthewwalsh0 mentioned this pull request Apr 16, 2025

feat: cp-12.16.1 support version 2.0.0 of EIP-5792 (#31913) #32023

Merged

7 tasks

matthewwalsh0 requested a review from OGPoyraz April 16, 2025 07:02

matthewwalsh0 requested review from jpuri and pedronfigueiredo April 16, 2025 07:02

matthewwalsh0 enabled auto-merge April 16, 2025 07:03

OGPoyraz approved these changes Apr 16, 2025

View reviewed changes

pedronfigueiredo approved these changes Apr 16, 2025

View reviewed changes

matthewwalsh0 added this pull request to the merge queue Apr 16, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2025

matthewwalsh0 added this pull request to the merge queue Apr 16, 2025

Merged via the queue into main with commit c566fc3 Apr 16, 2025
168 checks passed

matthewwalsh0 deleted the feat/eip-5792-atomic-capability branch April 16, 2025 11:15

github-actions bot locked and limited conversation to collaborators Apr 16, 2025

metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 16, 2025

vpintorico added the release-12.16.1 label Apr 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support version 2.0.0 of EIP-5792#31913

feat: support version 2.0.0 of EIP-5792#31913
matthewwalsh0 merged 14 commits intomainfrom
feat/eip-5792-atomic-capability

matthewwalsh0 commented Apr 11, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Apr 14, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 14, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

matthewwalsh0 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matthewwalsh0 commented Apr 11, 2025 •

edited

Loading

socket-security bot commented Apr 14, 2025 •

edited

Loading

metamaskbot commented Apr 14, 2025 •

edited

Loading