fix: Update origin in Snap requests#5616
Merged
FrederikBolding merged 2 commits intomainfrom Apr 9, 2025
Merged
Conversation
mirceanis
approved these changes
Apr 9, 2025
mirceanis
added a commit
to MetaMask/message-signing-snap
that referenced
this pull request
Apr 9, 2025
…pty string for origin see MetaMask/core#5616
mirceanis
added a commit
to MetaMask/message-signing-snap
that referenced
this pull request
Apr 9, 2025
…pty string for origin see MetaMask/core#5616
mirceanis
added a commit
to MetaMask/message-signing-snap
that referenced
this pull request
Apr 9, 2025
MetaMask internal calls now specify `metamask` as origin instead of the empty string. see MetaMask/core#5616
matallui
added a commit
that referenced
this pull request
Apr 9, 2025
* main: Fix unmocked block tracker warning in NetworkController tests (#5289) ci: GH action to remind developers to add release notes in CHANGELOG.md (#5620) Release 355.0.0 (#5619) Release 354.0.0 (#5615) fix: Update origin in Snap requests (#5616) Release/353.0.0 (#5612) refactor(accounts-controller): use type-cast instead of `@ts-expect-error` (#5568) feat: support external sign transactions (#5604) feat: extend isAtomicBatchSupported result (#5600) fix: Rename `enableTxParamsGasFeeUpdates` to `isAutomaticGasFeeUpdateEnabled` and also callback (#5602) Release/352.0.0 (#5608) feat: STAKE-1005: refresh staking data when staking txs are confirmed (#5607)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
We are making a change to the SnapController to more strictly validate the
originparameter. This disallows empty string which was previously allowed. This PR updates theprofile-sync-controllerto comply with these new requirements.Checklist