fix: Rename enableTxParamsGasFeeUpdates to isAutomaticGasFeeUpdateEnabled and also callback#5602
Conversation
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
vinistevam
previously approved these changes
Apr 7, 2025
matthewwalsh0
previously approved these changes
Apr 7, 2025
| * Callback to determine whether gas fee updates should be enabled for a given transaction. | ||
| * Returns true to enable updates, false to disable them. | ||
| */ | ||
| enableTxParamsGasFeeUpdates?: (transactionMeta: TransactionMeta) => boolean; |
Member
There was a problem hiding this comment.
Minor, should we take this chance to rename this to something more standard like isAutomaticGasFeeUpdateEnabled?
enableTxParamsGasFeeUpdates to callbackenableTxParamsGasFeeUpdates to isAutomaticGasFeeUpdateEnabled and also callback
vinistevam
approved these changes
Apr 8, 2025
matthewwalsh0
approved these changes
Apr 8, 2025
7 tasks
matallui
added a commit
that referenced
this pull request
Apr 9, 2025
* main: Fix unmocked block tracker warning in NetworkController tests (#5289) ci: GH action to remind developers to add release notes in CHANGELOG.md (#5620) Release 355.0.0 (#5619) Release 354.0.0 (#5615) fix: Update origin in Snap requests (#5616) Release/353.0.0 (#5612) refactor(accounts-controller): use type-cast instead of `@ts-expect-error` (#5568) feat: support external sign transactions (#5604) feat: extend isAtomicBatchSupported result (#5600) fix: Rename `enableTxParamsGasFeeUpdates` to `isAutomaticGasFeeUpdateEnabled` and also callback (#5602) Release/352.0.0 (#5608) feat: STAKE-1005: refresh staking data when staking txs are confirmed (#5607)
7 tasks
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Apr 11, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to update `TransactionController` version to latest. It adds `isAutomaticGasFeeUpdateEnabled` callback in order to adjust breaking change done here: MetaMask/core#5602 [](https://codespaces.new/MetaMask/metamask-extension/pull/31772?quickstart=1) ## **Related issues** Fixes: #14386 Fixes: #14551 ## **Manual testing steps** No manual test required. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to rename
enableTxParamsGasFeeUpdatestoisAutomaticGasFeeUpdateEnabledand make it a callback function instead of a boolean.This callback is invoked before performing
txParamsgas fee updates. The update will proceed only if the callback returns a truthy value.References
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4595
Mobile update PR: MetaMask/metamask-mobile#14470 (Not updated package yet since major update PR in review MetaMask/metamask-mobile#14326 )
Extension update PR:
Changelog
Checklist