Skip to content

chore: bump transaction-controller to 52.3.0#14326

Merged
OGPoyraz merged 18 commits intomainfrom
chore/bump-transaction-controller-52.1.0
Apr 9, 2025
Merged

chore: bump transaction-controller to 52.3.0#14326
OGPoyraz merged 18 commits intomainfrom
chore/bump-transaction-controller-52.1.0

Conversation

@mathieuartu
Copy link
Copy Markdown
Contributor

@mathieuartu mathieuartu commented Mar 31, 2025

Description

This PR bumps @metamask/transaction-controller to ^52.3.0

Related issues

Fixes:

Manual testing steps

  1. No manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu self-assigned this Mar 31, 2025
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-identity-deprecated DEPRECATED: team no longer exists label Mar 31, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 31, 2025

@mathieuartu mathieuartu added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Mar 31, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 84db215
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8cec1374-21d8-4bd8-bad8-90a38674a117

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d26f397
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86856451-6547-4526-aae0-714eb2ffd084

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz added Run Smoke E2E team-confirmations Push issues to confirmations team and removed Run Smoke E2E labels Apr 1, 2025
@OGPoyraz OGPoyraz changed the title chore: bump transaction-controller to 52.1.0 chore: bump transaction-controller to 52.3.0 Apr 1, 2025
@OGPoyraz OGPoyraz marked this pull request as ready for review April 1, 2025 09:24
@OGPoyraz OGPoyraz requested review from a team as code owners April 1, 2025 09:24
@OGPoyraz OGPoyraz requested a review from a team April 1, 2025 09:24
@OGPoyraz OGPoyraz requested a review from a team as a code owner April 1, 2025 09:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e2504fa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20781f2a-6d9d-4eff-b3d9-d0de8cd9709c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Apr 1, 2025
@jpuri jpuri requested a review from a team as a code owner April 1, 2025 10:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 212af36
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4601c2ab-1ca6-4be2-8e88-36171c51520f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

OGPoyraz added a commit to MetaMask/core that referenced this pull request Apr 8, 2025
…Enabled` and also callback (#5602)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

This PR aims to rename `enableTxParamsGasFeeUpdates` to
`isAutomaticGasFeeUpdateEnabled` and make it a callback function instead
of a boolean.
This callback is invoked before performing `txParams` gas fee updates.
The update will proceed only if the callback returns a truthy value.

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

Fixes: MetaMask/MetaMask-planning#4595
Mobile update PR: MetaMask/metamask-mobile#14470
(Not updated package yet since major update PR in review
MetaMask/metamask-mobile#14326 )
Extension update PR: 


## Changelog

<!--
THIS SECTION IS NO LONGER NEEDED.

The process for updating changelogs has changed. Please consult the
"Updating changelogs" section of the Contributing doc for more.
-->

## Checklist

- [X] I've updated the test suite for new or updated code as appropriate
- [X] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [X] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [X] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
OGPoyraz
OGPoyraz previously approved these changes Apr 9, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
65.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on assets side

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.45.0 Issue or pull request that will be included in release 7.45.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team team-identity-deprecated DEPRECATED: team no longer exists

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.