Skip to content

fix: Update TransactionController to latest#14574

Merged
OGPoyraz merged 1 commit intomainfrom
ogp/14551
Apr 11, 2025
Merged

fix: Update TransactionController to latest#14574
OGPoyraz merged 1 commit intomainfrom
ogp/14551

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Apr 10, 2025

Description

This PR aims to update TransactionController version to latest.

It adds isAutomaticGasFeeUpdateEnabled callback in order to adjust breaking change done here: MetaMask/core#5602

Open in GitHub Codespaces

Related issues

Fixes: #14386
Fixes: #14551

Manual testing steps

No manual test required.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner April 10, 2025 06:30
@OGPoyraz OGPoyraz requested a review from a team April 10, 2025 06:30
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Apr 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b838aa3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd478dc0-5a6e-4076-bcbf-7828f39c06b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 10, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/@metamask/transaction-controller@52.3.0 ⏵ 54.0.092 +510079 +1100 +1100

View full report ↗

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 11, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 59c9466 Apr 11, 2025
53 of 60 checks passed
@OGPoyraz OGPoyraz deleted the ogp/14551 branch April 11, 2025 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update metamask/transaction-controller to version 54.0.0 Update metamask/transaction-controller to version 53.0.0

4 participants

@OGPoyraz @pedronfigueiredo @tommasini @metamaskbot