Skip to content

Ignore this - Get gas price experiment#5637

Closed
kumavis wants to merge 6 commits intodevelopfrom
getGasPrice-experiment
Closed

Ignore this - Get gas price experiment#5637
kumavis wants to merge 6 commits intodevelopfrom
getGasPrice-experiment

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented Oct 30, 2018

No description provided.

@kumavis kumavis added the DO-NOT-MERGE Pull requests that should not be merged label Oct 30, 2018
@kumavis kumavis requested a review from frankiebee as a code owner October 30, 2018 08:28
@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Oct 30, 2018

test-e2e-beta-chrome is passing here

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Oct 30, 2018

test-e2e-beta-chrome is failing after moving to provider

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Oct 30, 2018

adding delay breaks a lot of e2e tests

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Oct 30, 2018

my best guess for the original chrome failure is some super sensitive timing issue, tho doesnt really make sense to me

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented Oct 30, 2018

reducing the timeout to zero gets the tests passing

@frankiebee
Copy link
Copy Markdown
Contributor

closing because of inactivity and ignore this feel free to reopen if relevant

@frankiebee frankiebee closed this Dec 19, 2018
@whymarrh whymarrh deleted the getGasPrice-experiment branch January 15, 2020 17:02
dbrans pushed a commit that referenced this pull request Apr 16, 2025
## **Description**

Cherry-pick of #31913 for `12.16.1`.

Creating manual PR as patch required for
`@metamask/transaction-controller`.

Patch changes are cherry-picks of
[#5600](MetaMask/core#5600),
[#5635](MetaMask/core#5635), and
[#5637](MetaMask/core#5637), built from
[patch/transaction-controller-extension-12-16-1](MetaMask/core@patch/transaction-controller-extension-12-16-0...patch/transaction-controller-extension-12-16-1).

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32023?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
matthewwalsh0 added a commit that referenced this pull request Apr 21, 2025
Cherry-pick of #31913 for `12.16.1`.

Creating manual PR as patch required for
`@metamask/transaction-controller`.

Patch changes are cherry-picks of
[#5600](MetaMask/core#5600),
[#5635](MetaMask/core#5635), and
[#5637](MetaMask/core#5637), built from
[patch/transaction-controller-extension-12-16-1](MetaMask/core@patch/transaction-controller-extension-12-16-0...patch/transaction-controller-extension-12-16-1).

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32023?quickstart=1)

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
MajorLift pushed a commit that referenced this pull request Apr 21, 2025
## **Description**

Cherry-pick of #31913 for `12.17.0`.

Creating manual PR as patch required for
`@metamask/transaction-controller`.

Patch changes are cherry-picks of
[#5635](MetaMask/core#5635) and
[#5637](MetaMask/core#5637), built from
[patch/transaction-controller-extension-12-17-0](MetaMask/core@@metamask/transaction-controller@54.0.0...patch/transaction-controller-extension-12-17-0).

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32144?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE Pull requests that should not be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants