Skip to content

feat: cp-12.17.0 support version 2.0.0 of EIP-5792 (#31913)#32144

Merged
MajorLift merged 2 commits intoVersion-v12.17.0from
cherry-pick/12-17-0-eip-5792-2-0-0
Apr 21, 2025
Merged

feat: cp-12.17.0 support version 2.0.0 of EIP-5792 (#31913)#32144
MajorLift merged 2 commits intoVersion-v12.17.0from
cherry-pick/12-17-0-eip-5792-2-0-0

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Apr 21, 2025

Description

Cherry-pick of #31913 for 12.17.0.

Creating manual PR as patch required for @metamask/transaction-controller.

Patch changes are cherry-picks of #5635 and #5637, built from patch/transaction-controller-extension-12-17-0.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Cherry-pick of #31913 for `12.16.1`.

Creating manual PR as patch required for
`@metamask/transaction-controller`.

Patch changes are cherry-picks of
[#5600](MetaMask/core#5600),
[#5635](MetaMask/core#5635), and
[#5637](MetaMask/core#5637), built from
[patch/transaction-controller-extension-12-16-1](MetaMask/core@patch/transaction-controller-extension-12-16-0...patch/transaction-controller-extension-12-16-1).

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32023?quickstart=1)

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Apr 21, 2025
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​test-dapp@​9.2.0 ⏵ 9.3.0941008996 +1100

View full report

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review April 21, 2025 11:46
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c0f7009]
UI Startup Metrics (1238 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1238113513885512711330
load10809811198541136988
domContentLoaded10749741193531131984
domInteractive18136691737
firstPaint768711199415245986
backgroundConnect8429578
firstReactRender21155762234
getState15642979
initialActions001000
loadScripts82773494152860921
setupStore8520379
WebpackHomeuiStartup20811693259820722242348
load16281309206416417301923
domContentLoaded16211305205416217221915
domInteractive171264111446
firstPaint161654195923284
backgroundConnect24988142659
firstReactRender184543851126091
getState12351789
initialActions318135
loadScripts16171300202715817201888
setupStore24731145249
FirefoxBrowserifyHomeuiStartup13861197180711914611608
load12391061166311813271461
domContentLoaded12391060166311813271461
domInteractive10536221348695
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213103142148
firstReactRender23193932432
getState1042052079
initialActions001001
loadScripts12201033164412013131446
setupStore842052067
WebpackHomeuiStartup15551380189811816051843
load13401194167410813961582
domContentLoaded13401194167410813951581
domInteractive9342153218896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22145062339
firstReactRender35295153747
getState9431689
initialActions102111
loadScripts13201177165710813751557
setupStore1263353389

@MajorLift MajorLift merged commit e520c61 into Version-v12.17.0 Apr 21, 2025
164 checks passed
@MajorLift MajorLift deleted the cherry-pick/12-17-0-eip-5792-2-0-0 branch April 21, 2025 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants