feat: cp-12.16.1 support version 2.0.0 of EIP-5792 (#31913) by matthewwalsh0 · Pull Request #32023 · MetaMask/metamask-extension

matthewwalsh0 · 2025-04-15T22:04:01Z

Description

Cherry-pick of #31913 for 12.16.1.

Creating manual PR as patch required for @metamask/transaction-controller.

Patch changes are cherry-picks of #5600, #5635, and #5637, built from patch/transaction-controller-extension-12-16-1.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-04-15T22:05:19Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/test-dapp@9.2.0 ⏵ 9.3.0	⁺⁸

View full report

metamaskbot · 2025-04-15T22:44:22Z

Builds ready [c9039f4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1200 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1200	1069	1450	68	1254	1307
			load	1047	913	1276	64	949	988
			domContentLoaded	1041	907	1272	64	947	990
			domInteractive	17	13	51	6	16	28
			firstPaint	732	132	1278	415	245	989
			backgroundConnect	10	6	54	6	9	10
			firstReactRender	19	15	52	5	19	32
			getState	11	4	33	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	828	702	1054	63	874	931
			setupStore	7	5	16	2	7	8
	Webpack	Home	uiStartup	1035	837	1344	82	962	994
			load	878	630	1004	63	913	973
			domContentLoaded	871	613	998	63	914	973
			domInteractive	16	12	45	7	14	37
			firstPaint	269	57	972	289	717	963
			backgroundConnect	18	13	50	8	17	42
			firstReactRender	16	12	34	5	17	27
			getState	5	3	28	4	5	6
			initialActions	0	0	2	0	0	1
			loadScripts	869	609	997	63	910	972
			setupStore	8	5	17	3	7	9
Firefox	Browserify	Home	uiStartup	1386	1217	1765	107	1475	1593
			load	1246	1093	1599	108	1328	1450
			domContentLoaded	1246	1092	1598	108	1327	1450
			domInteractive	100	41	158	26	89	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	99	9	24	33
			firstReactRender	23	19	38	3	26	28
			getState	7	4	36	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1222	1073	1572	106	1302	1426
			setupStore	6	4	18	2	6	7
	Webpack	Home	uiStartup	961	806	1402	162	872	987
			load	842	705	1214	145	777	890
			domContentLoaded	842	705	1214	145	777	890
			domInteractive	114	43	227	23	141	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	85	10	20	31
			firstReactRender	18	16	50	4	19	23
			getState	10	4	71	13	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	826	691	1191	141	764	878
			setupStore	8	5	58	9	7	8

metamaskbot · 2025-04-15T23:22:36Z

Builds ready [bfc2b32]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1090	1471	73	1255	1377
			load	1059	947	1318	70	1238	985
			domContentLoaded	1054	939	1313	70	1231	978
			domInteractive	16	13	29	4	16	28
			firstPaint	809	135	1234	398	221	974
			backgroundConnect	9	7	26	3	9	10
			firstReactRender	19	15	48	5	19	27
			getState	12	5	38	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	840	729	1095	70	882	940
			setupStore	8	5	29	3	7	8
	Webpack	Home	uiStartup	980	694	1225	87	966	993
			load	827	512	965	70	874	922
			domContentLoaded	820	499	954	71	865	914
			domInteractive	15	12	70	8	13	35
			firstPaint	237	58	909	240	68	93
			backgroundConnect	17	13	42	7	16	39
			firstReactRender	17	12	31	5	16	28
			getState	5	3	23	3	5	6
			initialActions	0	0	1	0	0	0
			loadScripts	818	497	952	70	857	912
			setupStore	7	5	19	3	7	9
Firefox	Browserify	Home	uiStartup	1403	1202	1766	108	1447	1684
			load	1261	1077	1646	110	1303	1547
			domContentLoaded	1261	1077	1646	110	1302	1546
			domInteractive	103	38	198	25	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	113	14	26	42
			firstReactRender	23	20	45	5	24	32
			getState	7	3	18	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1236	1060	1628	110	1274	1528
			setupStore	7	4	37	4	6	7
	Webpack	Home	uiStartup	1011	858	1489	165	917	972
			load	884	746	1317	149	824	974
			domContentLoaded	883	745	1316	149	824	974
			domInteractive	113	35	179	27	161	93
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	65	10	25	55
			firstReactRender	19	17	41	3	19	24
			getState	11	4	79	13	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	865	731	1289	145	809	960
			setupStore	9	5	59	8	8	9

metamaskbot · 2025-04-16T00:04:18Z

Builds ready [a3b7d1e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1203 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1203	1082	1424	61	1249	1302
			load	1047	927	1186	56	1151	986
			domContentLoaded	1041	915	1181	56	915	989
			domInteractive	16	13	35	4	16	29
			firstPaint	755	72	1149	405	246	980
			backgroundConnect	11	6	56	8	9	10
			firstReactRender	19	14	50	5	19	31
			getState	10	4	27	6	6	8
			initialActions	0	0	3	0	0	1
			loadScripts	823	694	956	56	871	917
			setupStore	8	5	20	3	7	8
	Webpack	Home	uiStartup	1059	880	1332	78	1130	988
			load	885	650	1000	54	911	970
			domContentLoaded	878	626	995	55	905	967
			domInteractive	17	12	53	7	16	34
			firstPaint	248	56	978	273	72	892
			backgroundConnect	19	14	47	8	18	42
			firstReactRender	18	13	38	6	18	34
			getState	6	3	24	3	5	7
			initialActions	0	0	1	0	0	1
			loadScripts	876	622	994	55	903	963
			setupStore	9	5	25	4	8	9
Firefox	Browserify	Home	uiStartup	1354	1157	1767	120	1393	1611
			load	1223	1043	1649	119	1270	1497
			domContentLoaded	1222	1043	1649	119	1270	1496
			domInteractive	95	40	171	24	90	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	224	23	23	31
			firstReactRender	22	19	51	4	22	27
			getState	6	4	16	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1199	1027	1631	116	1247	1461
			setupStore	6	4	19	2	6	7
	Webpack	Home	uiStartup	972	819	1439	170	875	946
			load	851	717	1257	149	783	938
			domContentLoaded	851	716	1257	148	783	938
			domInteractive	115	56	209	22	205	99
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	90	15	21	80
			firstReactRender	18	16	25	2	18	22
			getState	9	4	75	11	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	834	702	1230	145	768	919
			setupStore	9	4	72	12	7	8

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Apr 15, 2025

matthewwalsh0 force-pushed the cherry-pick/12-16-1-eip-5792-2-0-0 branch from c9039f4 to bfc2b32 Compare April 15, 2025 22:48

feat: support version 2.0.0 of EIP-5792 (#31913)

a3b7d1e

matthewwalsh0 force-pushed the cherry-pick/12-16-1-eip-5792-2-0-0 branch from bfc2b32 to a3b7d1e Compare April 15, 2025 23:27

matthewwalsh0 marked this pull request as ready for review April 16, 2025 01:16

matthewwalsh0 requested a review from a team as a code owner April 16, 2025 01:16

matthewwalsh0 requested review from OGPoyraz and pedronfigueiredo April 16, 2025 11:58

OGPoyraz approved these changes Apr 16, 2025

View reviewed changes

dbrans merged commit bdcefb3 into Version-v12.16.1 Apr 16, 2025
142 checks passed

dbrans deleted the cherry-pick/12-16-1-eip-5792-2-0-0 branch April 16, 2025 12:00

github-actions bot locked and limited conversation to collaborators Apr 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cp-12.16.1 support version 2.0.0 of EIP-5792 (#31913)#32023

feat: cp-12.16.1 support version 2.0.0 of EIP-5792 (#31913)#32023
dbrans merged 1 commit intoVersion-v12.16.1from
cherry-pick/12-16-1-eip-5792-2-0-0

matthewwalsh0 commented Apr 15, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Apr 15, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

matthewwalsh0 commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 15, 2025

Uh oh!

metamaskbot commented Apr 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matthewwalsh0 commented Apr 15, 2025 •

edited

Loading

socket-security bot commented Apr 15, 2025 •

edited

Loading