lavapack: Deprecate global,self as aliases for globalThis#461
Merged
Conversation
54d1bf0 to
73c7a00
Compare
73c7a00 to
6dac73d
Compare
6dac73d to
8fcecc4
Compare
legobeat
commented
Mar 8, 2023
Collaborator
Author
|
Updated to address potentially unaccounted for cases |
8fcecc4 to
dcd53b2
Compare
naugtur
reviewed
Mar 9, 2023
dcd53b2 to
662f95a
Compare
9be0007 to
988a02c
Compare
legobeat
commented
Mar 22, 2023
kumavis
reviewed
Mar 22, 2023
kumavis
reviewed
Mar 22, 2023
kumavis
reviewed
Mar 22, 2023
|
|
||
| // identify the globalRef | ||
| const globalRef = (typeof globalThis !== 'undefined') ? globalThis : (typeof self !== 'undefined') ? self : (typeof global !== 'undefined') ? global : undefined | ||
| let globalRef = globalThis |
Member
There was a problem hiding this comment.
this would fail under strict mode
Collaborator
Author
There was a problem hiding this comment.
Amended to address this and other review comments.
legobeat
commented
Mar 22, 2023
kumavis
reviewed
Mar 22, 2023
| }) | ||
|
|
||
| Object.defineProperty(globalThis, 'LavaPack', {value: LavaPack}) | ||
| Object.defineProperty(globalRef, 'LavaPack', {value: LavaPack}) |
1f62c7f to
41db44d
Compare
41db44d to
91e4363
Compare
weizman
approved these changes
Mar 22, 2023
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 (#552) - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551) - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts (#474) - core/fix - remove console taming to that errors are logged to the console correctly (#493) - core: fix globalThis polyfill (#567) - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis` (#461)
Merged
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 (#552) - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551) - Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - core/fix - remove console taming to that errors are logged to the console correctly (#493) - core: fix globalThis polyfill (#567) - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: remove object.fromentries, fromentries
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
naugtur
added a commit
that referenced
this pull request
May 17, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 17, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #459, which did the corresponding change in
core.