Wrap getters calling with try catch to avoid unhandled errors#468
Merged
Conversation
This was referenced Mar 9, 2023
Contributor
|
I can confirm that this fixed the issues I was having when executing in a sandboxed iframe. |
Member
|
Previously when we discussed this, try-catch in a loop was rejected because of performance impact. Should we benchmark this to actually know? |
Member
Author
|
I don't think we'll see any actual difference. It's an iteration of around 1000~ descriptors, nothing too crazy. |
naugtur
approved these changes
Mar 15, 2023
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts - core/fix - remove console taming to that errors are logged to the console correctly - core: fix globalThis polyfill - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis`
Merged
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts - core/fix - remove console taming to that errors are logged to the console correctly - core: fix globalThis polyfill - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis`
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 (#552) - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551) - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts (#474) - core/fix - remove console taming to that errors are logged to the console correctly (#493) - core: fix globalThis polyfill (#567) - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 (#552) - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551) - Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - core/fix - remove console taming to that errors are logged to the console correctly (#493) - core: fix globalThis polyfill (#567) - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: remove object.fromentries, fromentries
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
naugtur
added a commit
that referenced
this pull request
May 17, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 17, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling getters might throw and we need to catch there errors so the program will continue to execute (ctx)