Skip to content

core/fix - remove console taming to that errors are logged to the console correctly#493

Merged
kumavis merged 1 commit into
mainfrom
core-fix-tame-console
May 5, 2023
Merged

core/fix - remove console taming to that errors are logged to the console correctly#493
kumavis merged 1 commit into
mainfrom
core-fix-tame-console

Conversation

@kumavis

@kumavis kumavis commented May 5, 2023

Copy link
Copy Markdown
Member

I noticed errors were not being logged to the node console correctly, changing this option fixes that

@legobeat legobeat force-pushed the core-fix-tame-console branch from c97d19d to 1785d95 Compare May 5, 2023 12:15

@legobeat legobeat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kumavis kumavis merged commit 7464ccd into main May 5, 2023
@kumavis kumavis deleted the core-fix-tame-console branch May 5, 2023 17:39
@naugtur naugtur mentioned this pull request May 15, 2023
naugtur added a commit that referenced this pull request May 15, 2023
 - restrict engines.node to < 19.0.0 (#552)
 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551)
 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts (#474)
 - core/fix - remove console taming to that errors are logged to the console correctly (#493)
 - core: fix globalThis polyfill (#567)
 - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463)
 - drop uneeded additionalOpts arg and migrate back into using scenario object (#471)
 - Wrap getters calling with try catch (#468)
 - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
 - restrict engines.node to < 19.0.0 (#552)
 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551)
 - Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - core/fix - remove console taming to that errors are logged to the console correctly (#493)
 - core: fix globalThis polyfill (#567)
 - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463)
 - drop uneeded additionalOpts arg and migrate back into using scenario object (#471)
 - Wrap getters calling with try catch (#468)
 - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
legobeat pushed a commit that referenced this pull request May 15, 2023
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
legobeat pushed a commit that referenced this pull request May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
- change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
- fix: Restrict `engines.node` to < 19.0.0 (#552)
- fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
- fix: Remove console taming so that errors are logged to the console correctly (#493)
- fix: Fix globalThis polyfill (#567)
- fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
- fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
- fix: Catch errors thrown when calling property getters (#468)
- deps: remove object.fromentries, fromentries
legobeat added a commit that referenced this pull request May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
naugtur added a commit that referenced this pull request May 17, 2023
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 17, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants