Fix test scenario creation#471
Merged
Merged
Conversation
4c3d42b to
f11072c
Compare
68121a1 to
d1d1236
Compare
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts - core/fix - remove console taming to that errors are logged to the console correctly - core: fix globalThis polyfill - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis`
Merged
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts - core/fix - remove console taming to that errors are logged to the console correctly - core: fix globalThis polyfill - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis`
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 (#552) - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551) - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts (#474) - core/fix - remove console taming to that errors are logged to the console correctly (#493) - core: fix globalThis polyfill (#567) - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- restrict engines.node to < 19.0.0 (#552) - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551) - Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - core/fix - remove console taming to that errors are logged to the console correctly (#493) - core: fix globalThis polyfill (#567) - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463) - drop uneeded additionalOpts arg and migrate back into using scenario object (#471) - Wrap getters calling with try catch (#468) - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur
added a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
pushed a commit
that referenced
this pull request
May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: remove object.fromentries, fromentries
legobeat
added a commit
that referenced
this pull request
May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
naugtur
added a commit
that referenced
this pull request
May 17, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468)
legobeat
added a commit
that referenced
this pull request
May 17, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576) - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474) - change: Deprecate `global`,`self` as aliases for `globalThis` (#461) - fix: Restrict `engines.node` to < 19.0.0 (#552) - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551) - fix: Remove console taming so that errors are logged to the console correctly (#493) - fix: Fix globalThis polyfill (#567) - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463) - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471) - fix: Catch errors thrown when calling property getters (#468) - deps: dependency maintenance bumps - json-stable-stringify@^1.0.1->^1.0.2 - convert-source-map@^1.9.0->^2.0.0 - espree@^7.3.0->^9.5.2
legobeat
added a commit
that referenced
this pull request
May 30, 2023
c4857f3 browserify,node,tofu,viz: bump @babel packages to latest d557312 devDeps: eslint@^7.32.0->^8.40.0; plugins; lint:fix (#568) 93e1d2a devDeps: minor bump eslint packages (#568) 85a6ae2 core/version - 14.1.0 ccdd3d6 node/deps: yargs@16->17 73e54f6 deps: node-gyp-build@4.2.3->4.6.0 849f288 node/deps: json-stable-stringify@^1.0.1->^1.0.2 e0bf366 node/deps: remove object.fromentries (#555) 82beffa restrict engines.node to < 19.0.0 ced99e5 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/examples/express d5de5d5 drop uneeded additionalOpts arg and migrate back into using scenario object (#471) dc027eb core/version - 14.0.0 9a4759e node: yarn test:prep: force NODE_ENV=development for test projects setup 1de0a17 core/version - 13.0.0 23a9b06 Bump decode-uri-component in /packages/node/examples/express ec1c9b7 Bump decode-uri-component in /packages/node/test/projects/2 d8ea54f Bump express from 4.17.1 to 4.17.3 in /packages/node/examples/express 73dec5d Bump versions for core/lavapack/browserify (#431) 28e98d4 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/test/projects/2 e12aedd lint:fix 190391a fix: remove redundant engine entries from package.json (#411) 536e663 Less scary warning in README.md? (#403) 084fbb6 Improve eslint (#409) cee9caf Bump minimum nodejs version to 14.0.0 e90070f Fix for PR #382 [scuttling] (#391)
legobeat
added a commit
that referenced
this pull request
May 30, 2023
c4857f3 browserify,node,tofu,viz: bump @babel packages to latest d557312 devDeps: eslint@^7.32.0->^8.40.0; plugins; lint:fix (#568) 93e1d2a devDeps: minor bump eslint packages (#568) 85a6ae2 core/version - 14.1.0 ccdd3d6 node/deps: yargs@16->17 73e54f6 deps: node-gyp-build@4.2.3->4.6.0 849f288 node/deps: json-stable-stringify@^1.0.1->^1.0.2 e0bf366 node/deps: remove object.fromentries (#555) 82beffa restrict engines.node to < 19.0.0 ced99e5 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/examples/express d5de5d5 drop uneeded additionalOpts arg and migrate back into using scenario object (#471) dc027eb core/version - 14.0.0 9a4759e node: yarn test:prep: force NODE_ENV=development for test projects setup 1de0a17 core/version - 13.0.0 23a9b06 Bump decode-uri-component in /packages/node/examples/express ec1c9b7 Bump decode-uri-component in /packages/node/test/projects/2 d8ea54f Bump express from 4.17.1 to 4.17.3 in /packages/node/examples/express 73dec5d Bump versions for core/lavapack/browserify (#431) 28e98d4 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/test/projects/2 e12aedd lint:fix 190391a fix: remove redundant engine entries from package.json (#411) 536e663 Less scary warning in README.md? (#403) 084fbb6 Improve eslint (#409) cee9caf Bump minimum nodejs version to 14.0.0 e90070f Fix for PR #382 [scuttling] (#391)
legobeat
added a commit
that referenced
this pull request
Jun 2, 2023
c4857f3 browserify,node,tofu,viz: bump @babel packages to latest d557312 devDeps: eslint@^7.32.0->^8.40.0; plugins; lint:fix (#568) 93e1d2a devDeps: minor bump eslint packages (#568) 85a6ae2 core/version - 14.1.0 ccdd3d6 node/deps: yargs@16->17 73e54f6 deps: node-gyp-build@4.2.3->4.6.0 849f288 node/deps: json-stable-stringify@^1.0.1->^1.0.2 e0bf366 node/deps: remove object.fromentries (#555) 82beffa restrict engines.node to < 19.0.0 ced99e5 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/examples/express d5de5d5 drop uneeded additionalOpts arg and migrate back into using scenario object (#471) dc027eb core/version - 14.0.0 9a4759e node: yarn test:prep: force NODE_ENV=development for test projects setup 1de0a17 core/version - 13.0.0 23a9b06 Bump decode-uri-component in /packages/node/examples/express ec1c9b7 Bump decode-uri-component in /packages/node/test/projects/2 d8ea54f Bump express from 4.17.1 to 4.17.3 in /packages/node/examples/express 73dec5d Bump versions for core/lavapack/browserify (#431) 28e98d4 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/test/projects/2 e12aedd lint:fix 190391a fix: remove redundant engine entries from package.json (#411) 536e663 Less scary warning in README.md? (#403) 084fbb6 Improve eslint (#409) cee9caf Bump minimum nodejs version to 14.0.0 e90070f Fix for PR #382 [scuttling] (#391)
legobeat
added a commit
that referenced
this pull request
Jun 2, 2023
c4857f3 browserify,node,tofu,viz: bump @babel packages to latest d557312 devDeps: eslint@^7.32.0->^8.40.0; plugins; lint:fix (#568) 93e1d2a devDeps: minor bump eslint packages (#568) 85a6ae2 core/version - 14.1.0 ccdd3d6 node/deps: yargs@16->17 73e54f6 deps: node-gyp-build@4.2.3->4.6.0 849f288 node/deps: json-stable-stringify@^1.0.1->^1.0.2 e0bf366 node/deps: remove object.fromentries (#555) 82beffa restrict engines.node to < 19.0.0 ced99e5 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/examples/express d5de5d5 drop uneeded additionalOpts arg and migrate back into using scenario object (#471) dc027eb core/version - 14.0.0 9a4759e node: yarn test:prep: force NODE_ENV=development for test projects setup 1de0a17 core/version - 13.0.0 23a9b06 Bump decode-uri-component in /packages/node/examples/express ec1c9b7 Bump decode-uri-component in /packages/node/test/projects/2 d8ea54f Bump express from 4.17.1 to 4.17.3 in /packages/node/examples/express 73dec5d Bump versions for core/lavapack/browserify (#431) 28e98d4 Bump minimatch from 3.0.4 to 3.1.2 in /packages/node/test/projects/2 e12aedd lint:fix 190391a fix: remove redundant engine entries from package.json (#411) 536e663 Less scary warning in README.md? (#403) 084fbb6 Improve eslint (#409) cee9caf Bump minimum nodejs version to 14.0.0 e90070f Fix for PR #382 [scuttling] (#391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long time ago I added
additionalOptsto move across arguments such as scuttling related stuff.It was a mistake, these arguments can (and should) be integrated into the
scenarioobject.This PR fixes this (which will also help with #462)