Skip to content

Skip JSON files only for policy generation#474

Merged
legobeat merged 2 commits into
LavaMoat:mainfrom
FrederikBolding:fb/skip-json-files-only
May 11, 2023
Merged

Skip JSON files only for policy generation#474
legobeat merged 2 commits into
LavaMoat:mainfrom
FrederikBolding:fb/skip-json-files-only

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

Inverts the JSON file extension check to only check for .json. This allows for parsing of .cjs, .ts etc.

legobeat
legobeat reviewed Mar 25, 2023
View reviewed changes
Comment thread packages/core/src/generatePolicy.js Outdated
legobeat
legobeat reviewed Apr 25, 2023
View reviewed changes
Comment thread packages/core/src/generatePolicy.js Outdated
@legobeat legobeat requested review from a team and naugtur April 25, 2023 02:08
@legobeat legobeat force-pushed the fb/skip-json-files-only branch from 62e3874 to b25367d Compare April 25, 2023 09:32
@legobeat legobeat requested review from kumavis and weizman May 2, 2023 02:12
@legobeat legobeat force-pushed the fb/skip-json-files-only branch from 4bbf6b7 to 1adcce3 Compare May 5, 2023 21:48
@legobeat legobeat force-pushed the fb/skip-json-files-only branch from b7e8c15 to 041a208 Compare May 11, 2023 08:18
@legobeat legobeat force-pushed the fb/skip-json-files-only branch from 041a208 to 82d85b2 Compare May 11, 2023 08:26
@legobeat legobeat merged commit 39fa40e into LavaMoat:main May 11, 2023
@naugtur naugtur mentioned this pull request May 15, 2023
Merged
naugtur added a commit that referenced this pull request May 15, 2023
@naugtur
core/version - 14.1.0
1dd10a4 
 - restrict engines.node to < 19.0.0 (#552)
 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551)
 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts (#474)
 - core/fix - remove console taming to that errors are logged to the console correctly (#493)
 - core: fix globalThis polyfill (#567)
 - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463)
 - drop uneeded additionalOpts arg and migrate back into using scenario object (#471)
 - Wrap getters calling with try catch (#468)
 - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
@naugtur
core/version - 14.1.0
994a0fa 
 - restrict engines.node to < 19.0.0 (#552)
 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551)
 - Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - core/fix - remove console taming to that errors are logged to the console correctly (#493)
 - core: fix globalThis polyfill (#567)
 - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463)
 - drop uneeded additionalOpts arg and migrate back into using scenario object (#471)
 - Wrap getters calling with try catch (#468)
 - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
@naugtur
core/version - 14.1.0
b294a17 
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
@naugtur
core/version - 14.1.0
04e092c 
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 15, 2023
@legobeat
lavapack/version - 5.1.0
18ea2b8 
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
@legobeat legobeat mentioned this pull request May 15, 2023
Merged
legobeat pushed a commit that referenced this pull request May 15, 2023
@naugtur @legobeat
core/version - 14.1.0
edc303d 
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 15, 2023
@legobeat
lavapack/version - 5.1.0
587c7ce 
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
legobeat pushed a commit that referenced this pull request May 15, 2023
@naugtur @legobeat
core/version - 14.1.0
c016a55 
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
- change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
- fix: Restrict `engines.node` to < 19.0.0 (#552)
- fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
- fix: Remove console taming so that errors are logged to the console correctly (#493)
- fix: Fix globalThis polyfill (#567)
- fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
- fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
- fix: Catch errors thrown when calling property getters (#468)
- deps: remove object.fromentries, fromentries
legobeat added a commit that referenced this pull request May 15, 2023
@legobeat
lavapack/version - 5.1.0
988911c 
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
naugtur added a commit that referenced this pull request May 17, 2023
@naugtur
core/version - 14.1.0
85a6ae2 
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 17, 2023
@legobeat
lavapack/version - 5.1.0
b0e8119 
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naugtur naugtur naugtur approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@weizman weizman Awaiting requested review from weizman

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrederikBolding @naugtur @legobeat