Deprecate global,self as aliases for globalThis#459
Merged
Conversation
eec3cf4 to
02c9f28
Compare
02c9f28 to
76245c4
Compare
naugtur
approved these changes
Feb 28, 2023
Merged
Member
|
just saw this. we are now uttering possibly undefined vars without a typeof operator. this would throw in strict mode. this may have broken old node versions that we don't care about or support. so it's prolly fine. |
Collaborator
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #458 (comment)
This logs a deprecation warning if the fallbacks are being used, with intention for full removal likely in the next release.