Skip to content

core: fix globalThis polyfill#466

Merged
kumavis merged 2 commits into
LavaMoat:mainfrom
legobeat:fix-globals-strict-core
Mar 22, 2023
Merged

core: fix globalThis polyfill#466
kumavis merged 2 commits into
LavaMoat:mainfrom
legobeat:fix-globals-strict-core

Conversation

@legobeat

@legobeat legobeat commented Mar 8, 2023

Copy link
Copy Markdown
Collaborator

Motivation: #459 (comment)

we are now uttering possibly undefined vars without a typeof operator. this would throw in strict mode.

This reverts to using typeof

@legobeat legobeat marked this pull request as ready for review March 8, 2023 02:01
@legobeat legobeat requested review from a team, kumavis, naugtur and weizman March 9, 2023 02:46
@legobeat legobeat force-pushed the fix-globals-strict-core branch from 05bd296 to 89c3ebe Compare March 16, 2023 07:11
@legobeat legobeat force-pushed the fix-globals-strict-core branch from 89c3ebe to 197df95 Compare March 22, 2023 00:41
Comment thread packages/core/src/kernelTemplate.js Outdated
@kumavis kumavis merged commit a778b18 into LavaMoat:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants