Skip to content

Udpate heylogs (and fix CHANGELOG.md)#15671

Merged
koppor merged 1 commit into
mainfrom
update-heylogs
May 4, 2026
Merged

Udpate heylogs (and fix CHANGELOG.md)#15671
koppor merged 1 commit into
mainfrom
update-heylogs

Conversation

@koppor

@koppor koppor commented May 4, 2026

Copy link
Copy Markdown
Member

More fixes.

nbbrd/heylogs#483 was implemented and released.

Steps to test

See CI passing

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [/] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label May 4, 2026
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update heylogs to 0.17.1 and fix CHANGELOG.md links

✨ Enhancement 🐞 Bug fix

Grey Divider

Walkthroughs

Description 
• Updated heylogs CLI tool from version 0.16.1 to 0.17.1
• Fixed multiple malformed GitHub issue links in CHANGELOG.md
  - Removed trailing slashes from issue URLs
  - Corrected "pulls" to "pull" in URLs
  - Fixed typos in issue numbers and URL paths
Diagram 
flowchart LR
  A["heylogs CLI<br/>0.16.1"] -- "upgrade to" --> B["heylogs CLI<br/>0.17.1"]
  C["CHANGELOG.md<br/>malformed links"] -- "fix formatting" --> D["CHANGELOG.md<br/>corrected links"]
  B -- "validates" --> D
Loading

Grey Divider

File Changes

1. .github/workflows/tests-code.yml Dependencies +1/-1

Upgrade heylogs CLI dependency version

• Updated heylogs CLI version from 0.16.1 to 0.17.1 in the JBang command
• Maintains the same linting workflow for CHANGELOG.md validation

.github/workflows/tests-code.yml

2. CHANGELOG.md 🐞 Bug fix +9/-9

Fix malformed GitHub links in changelog

• Removed trailing slashes from GitHub issue URLs (e.g., #12832/ → #12832)
• Changed incorrect "pulls" endpoint to "pull" in URLs
• Fixed malformed URL path pull/793://github.com/JabRef/jabref/pull/7921 to correct issue link
• Fixed typo in issue number 9864s to 9864
• Corrected parentheses formatting in one issue link from ([#14017](...)) to [#14017](...)

CHANGELOG.md

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

Grey Divider

Looking for bugs?

Check back in a few minutes. An AI review agent is analyzing this pull request.

Grey Divider

Qodo Logo

@koppor koppor enabled auto-merge May 4, 2026 15:46
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CI Feedback 🧐

(Feedback updated until commit 5f4a98a)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: CHANGELOG.md - only unreleased touched

Failed stage: Check CHANGELOG.md diff [❌]

Failed test name: ""

Failure summary:

The action failed because a file content check/diff step detected unexpected differences and
returned a non-zero exit code (exit code 1).
The diff shows mismatches in release note
entries/links, including:
- Incorrect GitHub URL paths and typos (e.g., issues/9864s vs issues/9864,
pulls/8264 vs pull/8264).
- A malformed link for #7912 (pull/793://github.com/...) that differs from
the expected correct link.
- Unwanted /files suffixes in PR links (pull/6963/files, pull/7007/files)
compared to expected pull/6963 and pull/7007.

Relevant error logs: 
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

462:  ---
463:  >       "fixed": "We fixed an issue where JabRref wrote wrong field names into the PDF. [#12833](https://github.com/JabRef/jabref/pull/12833)"
464:  2253c2253
465:  <       "changed": "We improved the recognition of DOIs when pasting a link containing a DOI on the maintable. [#9864](https://github.com/JabRef/jabref/issues/9864s)"
466:  ---
467:  >       "changed": "We improved the recognition of DOIs when pasting a link containing a DOI on the maintable. [#9864](https://github.com/JabRef/jabref/issues/9864)"
468:  3243c3243
469:  <       "changed": "We reworked the library properties dialog and integrated the `Library > Preamble`, `Library > Citation key pattern` and `Library > String constants dialogs` [#8264](https://github.com/JabRef/jabref/pulls/8264)"
470:  ---
471:  >       "changed": "We reworked the library properties dialog and integrated the `Library > Preamble`, `Library > Citation key pattern` and `Library > String constants dialogs` [#8264](https://github.com/JabRef/jabref/pull/8264)"
472:  3270c3270
473:  <       "fixed": "We fixed an issue where it was impossible to add or modify groups. [#7912](https://github.com/JabRef/jabref/pull/793://github.com/JabRef/jabref/pull/7921)"
474:  ---
475:  >       "fixed": "We fixed an issue where it was impossible to add or modify groups. [#7912](https://github.com/JabRef/jabref/issues/7912)"
476:  3796c3796
477:  <       "fixed": "We fixed an issue with the python script used by browser plugins that failed to locate JabRef if not installed in its default location. [#6963](https://github.com/JabRef/jabref/pull/6963/files)"
478:  ---
479:  >       "fixed": "We fixed an issue with the python script used by browser plugins that failed to locate JabRef if not installed in its default location. [#6963](https://github.com/JabRef/jabref/pull/6963)"
480:  3805c3805
481:  <       "fixed": "We fixed an issue where the RIS exporter added extra blank lines.[#7007](https://github.com/JabRef/jabref/pull/7007/files)"
482:  ---
483:  >       "fixed": "We fixed an issue where the RIS exporter added extra blank lines.[#7007](https://github.com/JabRef/jabref/pull/7007)"
484:  ##[error]Process completed with exit code 1.
485:  Post job cleanup.

@koppor koppor disabled auto-merge May 4, 2026 15:47
@koppor koppor merged commit a3830e1 into main May 4, 2026
58 of 68 checks passed
qodo-free-for-open-source-projects[bot]
qodo-free-for-open-source-projects Bot reviewed May 4, 2026
View reviewed changes
Comment thread .github/workflows/tests-code.yml
Comment on lines +189 to 192
jbang com.github.nbbrd.heylogs:heylogs-cli:0.17.1:bin check CHANGELOG.md | tee heylogs.txt || true

# We have two acceptable errors
if ! grep -q "1 problem" heylogs.txt; then

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Fragile heylogs pass condition 🐞 Bug ☼ Reliability

The CHANGELOG lint job ignores heylogs’ exit code and instead only passes when the output contains
the literal substring "1 problem", so it will fail if heylogs reports "0 problems" (valid changelog)
or changes its summary wording/format. Upgrading heylogs to 0.17.1 increases the likelihood of CI
breaking due to this hard-coded output match.
Agent Prompt 
### Issue description
The CI job `Lint CHANGELOG.md` currently ignores the heylogs command exit code and instead checks for a specific substring in stdout (`"1 problem"`). This is brittle: if heylogs reports `0 problems` (or changes wording in 0.17.1+), CI will fail even when CHANGELOG.md is valid.

### Issue Context
Current behavior:
- `jbang ... check ... | tee heylogs.txt || true` discards the actual exit status.
- The job passes only if `heylogs.txt` contains `"1 problem"`.

### Fix Focus Areas
- .github/workflows/tests-code.yml[186-199]

### Implementation guidance
- Prefer relying on heylogs’ exit code (remove `|| true`, and use `set -o pipefail` so the pipeline fails when heylogs fails), OR
- If you must allow a specific set of known failures, parse a machine-readable output (if supported) or implement an explicit allowlist that accepts both `0` and the intended acceptable count(s), rather than hard-coding `"1 problem"`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@koppor koppor deleted the update-heylogs branch May 4, 2026 15:51
Siedlerchr added a commit to FynnianB/jabref that referenced this pull request May 4, 2026
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into feature/jabsrv-secu…
b49185f 
…rity

* upstream/main: (204 commits)
  New Crowdin updates (JabRef#15669)
  Fix OpenRewrite (JabRef#15670)
  Udpate heylogs (and fix CHANGELOG.md) (JabRef#15671)
  Improve security and prevent shell injection for push2applications (JabRef#15628)
  Fix depdency analysis (JabRef#15668)
  Always use CI-local "gradle", instead of gradlew (JabRef#15667)
  Change OpenRewrite task to use rewriteDryRun (JabRef#15664)
  Add small documentation to parameter (JabRef#15666)
  Fix markbaseChanged for "imported entries" (JabRef#15610)
  Add forgotten --fresh
  chore(deps): update dependency com.github.ben-manes.caffeine:caffeine to v3.2.4 (JabRef#15662)
  chore(deps): update jackson monorepo to v3.1.3 (JabRef#15659)
  chore(deps): update dependency org.glassfish.hk2:hk2-utils to v4.0.1 (JabRef#15657)
  chore(deps): update dependency org.glassfish.hk2:hk2-locator to v4.0.1 (JabRef#15656)
  fix gemsfx missing icon resolving (JabRef#15655)
  chore(deps): update dependency org.glassfish.hk2:hk2-api to v4.0.1 (JabRef#15654)
  chore(deps): update dependency org.postgresql:postgresql to v42.7.11 (JabRef#15634)
  Chore(deps): Bump tools.jackson:jackson-bom in /versions (JabRef#15653)
  Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15652)
  Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (JabRef#15651)
  ...
Siedlerchr added a commit that referenced this pull request May 5, 2026
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into add-oauth2
1292da7 
* upstream/main: (775 commits)
  Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#15682)
  Chore(deps): Bump org.glassfish.jaxb:jaxb-runtime in /versions (#15681)
  Update dependency com.konghq:unirest-modules-gson to v4.9.0 (#15679)
  Integrate with SearchRxiv  (#15373)
  Fix requirements (#15600)
  refactor: less objects during writing (#15677)
  Fix: suppress WARN for empty or blank column name in MainTableColumnModel#parse() (#15576)
  New Crowdin updates (#15676)
  Chore(deps): Bump com.github.ben-manes.caffeine:caffeine in /versions (#15673)
  Fix Nullwarnings - C (Mark bst package as nonnull by default) (#15663)
  Chore(deps): Bump com.github.javaparser:javaparser-symbol-solver-core (#15674)
  Chore(deps): Bump com.github.javaparser:javaparser-core in /versions (#15672)
  New Crowdin updates (#15669)
  Fix OpenRewrite (#15670)
  Udpate heylogs (and fix CHANGELOG.md) (#15671)
  Improve security and prevent shell injection for push2applications (#15628)
  Fix depdency analysis (#15668)
  Always use CI-local "gradle", instead of gradlew (#15667)
  Change OpenRewrite task to use rewriteDryRun (#15664)
  Add small documentation to parameter (#15666)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects[bot] qodo-free-for-open-source-projects[bot] left review comments

@jabref-machine jabref-machine jabref-machine approved these changes

Assignees

No one assigned

Labels

automerge PR is tagged with that label will be merged if workflows are green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @jabref-machine