• Move "imported entries" group creation to post-open action
• Prevent unwanted database modification marker when importing
• Simplify active database setter with Optional.ofNullable
• Remove duplicate group creation logic from view model

Simplify active database setter with Optional

• Added @Nullable import annotation
• Changed setActiveDatabase parameter to accept null values
• Simplified null handling using Optional.ofNullable instead of conditional logic

jabgui/src/main/java/org/jabref/gui/JabRefGuiStateManager.java

Remove imported entries group creation logic

• Removed addGroupImportEntries method entirely
• Removed group creation logic from onActiveDatabaseChanged
• Simplified database change handler to only update view model state
• Moved responsibility to post-open action phase

jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

New post-open action for imported entries group

• New action class implementing GUIPostOpenAction interface
• isActionNecessary checks preference and verifies group doesn't exist
• performAction creates root group if absent and inserts import group at position 0
• Executes during file parsing before GUI setup to avoid modification marker

jabgui/src/main/java/org/jabref/gui/importer/actions/AddGroupImportEntriesAction.java

Description

The “Imported entries” group is now only created via OpenDatabaseAction post-open actions, so
libraries created via NewDatabaseAction never get the group even when the preference is enabled, and
importing into such libraries won’t assign entries to the group. This also breaks existing
GroupTreeViewModel tests that still assert the group is created during GroupTreeViewModel
initialization.

Code

jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java[R166-187]

private void onActiveDatabaseChanged(Optional<BibDatabaseContext> newDatabase) {
-        if (newDatabase.isPresent()) {
-            GroupNodeViewModel newRoot = newDatabase
-                    .map(BibDatabaseContext::getMetaData)
-                    .flatMap(MetaData::getGroups)
-                    .map(root -> new GroupNodeViewModel(newDatabase.get(), stateManager, taskExecutor, root, localDragboard, preferences))
-                    .orElse(GroupNodeViewModel.getAllEntriesGroup(newDatabase.get(), stateManager, taskExecutor, localDragboard, preferences));
-
-            rootGroup.setValue(newRoot);
-            if (stateManager.getSelectedGroups(newDatabase.get()).isEmpty()) {
-                stateManager.setSelectedGroups(newDatabase.get(), List.of(newRoot.getGroupNode()));
-            }
-            selectedGroups.setAll(
-                    stateManager.getSelectedGroups(newDatabase.get()).stream()
-                                .map(selectedGroup -> new GroupNodeViewModel(newDatabase.get(), stateManager, taskExecutor, selectedGroup, localDragboard, preferences))
-                                .collect(Collectors.toList()));
-        } else {
-            rootGroup.setValue(null);
-        }
    currentDatabase = newDatabase;
-        newDatabase.ifPresent(_ -> addGroupImportEntries(rootGroup.get()));
-    }
-
-    /// Creates the "Imported entries" group if enabled and missing.
-    /// Selection is disabled to prevent focus theft when switching tabs.
-    private void addGroupImportEntries(GroupNodeViewModel parent) {
-        if (!preferences.getLibraryPreferences().shouldAddImportedEntries()) {
+        if (newDatabase.isEmpty()) {
+            rootGroup.setValue(null);
        return;
    }
-        String groupName = preferences.getLibraryPreferences().getAddImportedEntriesGroupName();
-        boolean groupExists = parent.getGroupNode()
-                                    .getChildren()
-                                    .stream()
-                                    .map(GroupTreeNode::getGroup)
-                                    .anyMatch(grp -> grp instanceof ExplicitGroup && grp.getName().equalsIgnoreCase(groupName));
-        if (!groupExists) {
-            currentDatabase.ifPresent(db -> {
-                char keywordSeparator = preferences.getBibEntryPreferences().getKeywordSeparator();
-                AbstractGroup importEntriesGroup = new ExplicitGroup(groupName, GroupHierarchyType.INDEPENDENT, keywordSeparator);
-                GroupTreeNode newSubgroup = parent.addSubgroup(importEntriesGroup);
-                newSubgroup.moveTo(parent.getGroupNode(), 0);
-                writeGroupChangesToMetaData();
-            });
+        GroupNodeViewModel newRoot = newDatabase
+                .map(BibDatabaseContext::getMetaData)
+                .flatMap(MetaData::getGroups)
+                .map(root -> new GroupNodeViewModel(newDatabase.get(), stateManager, taskExecutor, root, localDragboard, preferences))
+                .orElse(GroupNodeViewModel.getAllEntriesGroup(newDatabase.get(), stateManager, taskExecutor, localDragboard, preferences));
+
+        rootGroup.setValue(newRoot);
+        if (stateManager.getSelectedGroups(newDatabase.get()).isEmpty()) {
+            stateManager.setSelectedGroups(newDatabase.get(), List.of(newRoot.getGroupNode()));
    }
+        selectedGroups.setAll(
+                stateManager.getSelectedGroups(newDatabase.get()).stream()
+                            .map(selectedGroup -> new GroupNodeViewModel(newDatabase.get(), stateManager, taskExecutor, selectedGroup, localDragboard, preferences))
+                            .collect(Collectors.toList()));
}

Evidence

GroupTreeViewModel no longer creates the “Imported entries” group on active database changes, while
AddGroupImportEntriesAction is only wired into the file-open pipeline (OpenDatabaseAction). New
libraries are created through NewDatabaseAction without running post-open actions, and ImportHandler
only adds entries to an already-existing group (it explicitly does not create it), so the feature
silently does nothing for new/untitled libraries. The existing unit test suite still expects
GroupTreeViewModel to create this group when enabled, which will now fail.

jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java[164-187]
jabgui/src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java[57-66]
jabgui/src/main/java/org/jabref/gui/importer/NewDatabaseAction.java[23-28]
jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java[539-552]
jabgui/src/test/java/org/jabref/gui/groups/GroupTreeViewModelTest.java[205-226]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The “Imported entries” group is only created during the **file-open** flow (post-open actions), so **new/untitled libraries** never get the group when the preference is enabled. As a result, imports into new libraries won’t be assigned to the group, and existing unit tests expecting GroupTreeViewModel to create the group will fail.
### Issue Context
- Group creation was removed from `GroupTreeViewModel.onActiveDatabaseChanged`.
- `AddGroupImportEntriesAction` is only registered in `OpenDatabaseAction.POST_OPEN_ACTIONS`.
- `NewDatabaseAction` creates a new `BibDatabaseContext` and adds a tab, but does not run post-open actions.
- `ImportHandler.addToImportEntriesGroup` only adds to an existing group and will not create it.
### Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/importer/NewDatabaseAction.java[23-28]
- jabgui/src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java[57-66]
- jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java[164-187]
- jabgui/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java[539-552]
- jabgui/src/test/java/org/jabref/gui/groups/GroupTreeViewModelTest.java[205-226]
### What to change
- Ensure the “Imported entries” group is created for **new libraries** too (e.g., invoke the same logic used by `AddGroupImportEntriesAction` during new-library creation, or add a shared helper that can be called from both open and new flows).
- Update/adjust the GroupTreeViewModel tests to reflect the new responsibility boundary (either restore creation in the view model for non-open flows, or change tests to validate group creation through the new action/hook).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

The newly added stream code uses collect(Collectors.toList()) where the modern Stream.toList()
would be clearer and consistent with the configured modern Java toolchain expectations. This
introduces an outdated Java idiom in new/modified code.

Code

jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java[R183-186]

+        selectedGroups.setAll(
+                stateManager.getSelectedGroups(newDatabase.get()).stream()
+                            .map(selectedGroup -> new GroupNodeViewModel(newDatabase.get(), stateManager, taskExecutor, selectedGroup, localDragboard, preferences))
+                            .collect(Collectors.toList()));

Evidence

PR Compliance ID 4 requires preferring modern Java APIs/idioms in new/changed code; the modified
lines use collect(Collectors.toList()) for a simple terminal collection where toList() is
available and preferred.

AGENTS.md
jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java[183-186]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
New/modified code uses the older `collect(Collectors.toList())` idiom instead of the modern `Stream.toList()`.
## Issue Context
The project targets a modern Java toolchain and prefers newer standard library idioms when available.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java[183-186]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

The added CHANGELOG.md bullet is awkwardly phrased (fixed an issue for marking...) and may be
unclear to end users. This reduces the professionalism/readability of user-facing release notes.

Code

CHANGELOG.md[99]

+- We fixed an issue for marking a library as modified when "imported entries" group was enabled.

Evidence

PR Compliance IDs 31 and 37 require end-user oriented, professional, well-formatted release notes;
the added sentence contains a grammatical/phrasing issue that can confuse readers.

AGENTS.md
CHANGELOG.md[99-99]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly added CHANGELOG bullet is grammatically awkward and may not be easily understood by end users.
## Issue Context
CHANGELOG entries are user-facing release notes and should be professionally written and clear.
## Fix Focus Areas
- CHANGELOG.md[99-99]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools