Skip to content

New Crowdin updates#15669

Merged
Siedlerchr merged 26 commits into
mainfrom
l10n_main
May 4, 2026
Merged

New Crowdin updates#15669
Siedlerchr merged 26 commits into
mainfrom
l10n_main

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

No description provided.

Siedlerchr added 25 commits May 3, 2026 22:50
@koppor koppor enabled auto-merge May 3, 2026 20:51
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update localization files with Vim section comments and remove obsolete messages

📝 Documentation

Grey Divider

Walkthroughs

Description
• Add "Pushing to applications" section comment across 25 language files
• Remove obsolete "Could not call executable" error message translations
• Normalize whitespace and formatting in localization properties files
• Update translations for Vim-related error messages and UI strings
Diagram
flowchart LR
  A["25 Language<br/>Properties Files"] -->|Remove| B["Obsolete Error<br/>Messages"]
  A -->|Add| C["Pushing to<br/>Applications Comment"]
  A -->|Normalize| D["Whitespace &<br/>Formatting"]
  B --> E["Updated<br/>Localization Files"]
  C --> E
  D --> E
Loading

Grey Divider

File Changes

1. jablib/src/main/resources/l10n/JabRef_ar.properties 📝 Documentation +3/-2

Add Vim section comment and normalize spacing

jablib/src/main/resources/l10n/JabRef_ar.properties


2. jablib/src/main/resources/l10n/JabRef_da.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_da.properties


3. jablib/src/main/resources/l10n/JabRef_de.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_de.properties


View more (22)
4. jablib/src/main/resources/l10n/JabRef_el.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_el.properties


5. jablib/src/main/resources/l10n/JabRef_es.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_es.properties


6. jablib/src/main/resources/l10n/JabRef_fa.properties 📝 Documentation +3/-2

Add Vim section comment and normalize spacing

jablib/src/main/resources/l10n/JabRef_fa.properties


7. jablib/src/main/resources/l10n/JabRef_fi.properties 📝 Documentation +1/-0

Add Vim section comment to properties file

jablib/src/main/resources/l10n/JabRef_fi.properties


8. jablib/src/main/resources/l10n/JabRef_fr.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_fr.properties


9. jablib/src/main/resources/l10n/JabRef_id.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_id.properties


10. jablib/src/main/resources/l10n/JabRef_it.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_it.properties


11. jablib/src/main/resources/l10n/JabRef_ja.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_ja.properties


12. jablib/src/main/resources/l10n/JabRef_ko.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_ko.properties


13. jablib/src/main/resources/l10n/JabRef_nl.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_nl.properties


14. jablib/src/main/resources/l10n/JabRef_no.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_no.properties


15. jablib/src/main/resources/l10n/JabRef_pl.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_pl.properties


16. jablib/src/main/resources/l10n/JabRef_pt.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_pt.properties


17. jablib/src/main/resources/l10n/JabRef_pt_BR.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_pt_BR.properties


18. jablib/src/main/resources/l10n/JabRef_ru.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_ru.properties


19. jablib/src/main/resources/l10n/JabRef_sv.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_sv.properties


20. jablib/src/main/resources/l10n/JabRef_tl.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_tl.properties


21. jablib/src/main/resources/l10n/JabRef_tr.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_tr.properties


22. jablib/src/main/resources/l10n/JabRef_uk.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_uk.properties


23. jablib/src/main/resources/l10n/JabRef_vi.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_vi.properties


24. jablib/src/main/resources/l10n/JabRef_zh_CN.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_zh_CN.properties


25. jablib/src/main/resources/l10n/JabRef_zh_TW.properties 📝 Documentation +3/-3

Remove obsolete executable error, add Vim comment

jablib/src/main/resources/l10n/JabRef_zh_TW.properties


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Removed l10n key translation🐞 Bug ≡ Correctness
Description
The key "Could not call executable" is still used (e.g., in AbstractPushToApplication), but its
translations were removed from many non-English bundles (e.g., JabRef_de.properties), so users will
see the raw key text instead of a translated message. This regression is silent because the
localization bundle returns the key itself for missing entries and does not log the missing
translation.
Code

jablib/src/main/resources/l10n/JabRef_de.properties[126]

-Could\ not\ call\ executable=Konnte das Programm nicht aufrufen
Evidence
AbstractPushToApplication still requests the localized string for "Could not call executable". After
this PR, the German bundle no longer contains the corresponding properties entry (it jumps from
"Copy to clipboard" to the next key), so the localized resource set for that locale will not provide
a translated value. The localization layer loads only the locale-specific ResourceBundle (base name
"l10n/JabRef") and the fallback behavior returns the key itself when the lookup map lacks an entry,
which means the untranslated English key becomes user-visible without a warning.

jablib/src/main/java/org/jabref/logic/push/AbstractPushToApplication.java[95-105]
jablib/src/main/resources/l10n/JabRef_de.properties[121-131]
jablib/src/main/java/org/jabref/logic/l10n/Localization.java[103-107]
jablib/src/main/java/org/jabref/logic/l10n/Localization.java[139-168]
jablib/src/main/resources/l10n/JabRef_en.properties[128-134]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The localization key `Could not call executable` is still used in code (`Localization.lang("Could not call executable")`), but the corresponding properties entry was removed from many non-English localization files (e.g., `JabRef_de.properties`). This causes non-English locales to show the raw key text (English) instead of a translation.
### Issue Context
`Localization` loads `ResourceBundle.getBundle("l10n/JabRef", locale)`. For missing keys in a locale file, `LocalizationBundle.handleGetObject` returns the key itself, and `containsKey()` always returns `true`, so the issue becomes a silent UX regression.
### Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_de.properties[121-131]
- jablib/src/main/java/org/jabref/logic/push/AbstractPushToApplication.java[95-105]
- jablib/src/main/resources/l10n/JabRef_en.properties[128-134]
### Expected fix
Re-add the properties entry `Could\ not\ call\ executable=...` to each affected non-English `JabRef_<lang>.properties` file (ideally restoring the previous translations). If restoring per-locale translations is not possible in this PR, add at least an English placeholder value to prevent a missing-entry fallback, and ensure Crowdin will later overwrite it with proper translations.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Extra blank lines in l10n 📘 Rule violation ⚙ Maintainability
Description
Multiple localization .properties files introduce whitespace-only lines that do not change any
keys/values, creating review noise and increasing merge-conflict risk. This is unrelated
reformatting rather than a functional localization update.
Code

jablib/src/main/resources/l10n/JabRef_de.properties[R61-62]

+
+
Evidence
PR Compliance ID 2 requires avoiding unrelated formatting changes; the diff shows multiple
added/removed empty lines in translation files without any accompanying functional key/value changes
in those hunks.

AGENTS.md
jablib/src/main/resources/l10n/JabRef_de.properties[61-62]
jablib/src/main/resources/l10n/JabRef_ar.properties[32-33]
jablib/src/main/resources/l10n/JabRef_da.properties[37-38]
jablib/src/main/resources/l10n/JabRef_es.properties[61-62]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Several l10n `.properties` files include whitespace-only additions/removals that are unrelated to actual translation key/value updates.
## Issue Context
These changes increase diff noise and merge-conflict likelihood without improving functionality.
## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_de.properties[61-62]
- jablib/src/main/resources/l10n/JabRef_ar.properties[32-33]
- jablib/src/main/resources/l10n/JabRef_da.properties[37-38]
- jablib/src/main/resources/l10n/JabRef_es.properties[61-62]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment thread jablib/src/main/resources/l10n/JabRef_de.properties
@Siedlerchr Siedlerchr disabled auto-merge May 4, 2026 18:45
@Siedlerchr Siedlerchr merged commit fc489e9 into main May 4, 2026
40 of 44 checks passed
@Siedlerchr Siedlerchr deleted the l10n_main branch May 4, 2026 18:46
Siedlerchr added a commit to FynnianB/jabref that referenced this pull request May 4, 2026
…rity

* upstream/main: (204 commits)
  New Crowdin updates (JabRef#15669)
  Fix OpenRewrite (JabRef#15670)
  Udpate heylogs (and fix CHANGELOG.md) (JabRef#15671)
  Improve security and prevent shell injection for push2applications (JabRef#15628)
  Fix depdency analysis (JabRef#15668)
  Always use CI-local "gradle", instead of gradlew (JabRef#15667)
  Change OpenRewrite task to use rewriteDryRun (JabRef#15664)
  Add small documentation to parameter (JabRef#15666)
  Fix markbaseChanged for "imported entries" (JabRef#15610)
  Add forgotten --fresh
  chore(deps): update dependency com.github.ben-manes.caffeine:caffeine to v3.2.4 (JabRef#15662)
  chore(deps): update jackson monorepo to v3.1.3 (JabRef#15659)
  chore(deps): update dependency org.glassfish.hk2:hk2-utils to v4.0.1 (JabRef#15657)
  chore(deps): update dependency org.glassfish.hk2:hk2-locator to v4.0.1 (JabRef#15656)
  fix gemsfx missing icon resolving (JabRef#15655)
  chore(deps): update dependency org.glassfish.hk2:hk2-api to v4.0.1 (JabRef#15654)
  chore(deps): update dependency org.postgresql:postgresql to v42.7.11 (JabRef#15634)
  Chore(deps): Bump tools.jackson:jackson-bom in /versions (JabRef#15653)
  Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15652)
  Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (JabRef#15651)
  ...
Siedlerchr added a commit that referenced this pull request May 5, 2026
* upstream/main: (775 commits)
  Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#15682)
  Chore(deps): Bump org.glassfish.jaxb:jaxb-runtime in /versions (#15681)
  Update dependency com.konghq:unirest-modules-gson to v4.9.0 (#15679)
  Integrate with SearchRxiv  (#15373)
  Fix requirements (#15600)
  refactor: less objects during writing (#15677)
  Fix: suppress WARN for empty or blank column name in MainTableColumnModel#parse() (#15576)
  New Crowdin updates (#15676)
  Chore(deps): Bump com.github.ben-manes.caffeine:caffeine in /versions (#15673)
  Fix Nullwarnings - C (Mark bst package as nonnull by default) (#15663)
  Chore(deps): Bump com.github.javaparser:javaparser-symbol-solver-core (#15674)
  Chore(deps): Bump com.github.javaparser:javaparser-core in /versions (#15672)
  New Crowdin updates (#15669)
  Fix OpenRewrite (#15670)
  Udpate heylogs (and fix CHANGELOG.md) (#15671)
  Improve security and prevent shell injection for push2applications (#15628)
  Fix depdency analysis (#15668)
  Always use CI-local "gradle", instead of gradlew (#15667)
  Change OpenRewrite task to use rewriteDryRun (#15664)
  Add small documentation to parameter (#15666)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants