Fix requirements#15600
Conversation
Resolve duplicate req~ui.dialogs.confirmation.naming~1 by linking ui-recommendations.md to the canonical definition in ux.md. Drop unmet "Needs: impl" from the two aspirational search requirements and add an impl marker for req~ux.disabled-vs-hidden~1 in OpenUrlAction (the exact example from the requirement). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Does this happen also in main? Run gradle checkAllModuleInfo |
Yes |
|
Filed issue for that: https://github.com/JabRef/jabref-issue-melting-pot/issues/1290 |
|
Can this be merged? |
Review Summary by QodoFix requirements tracing and consolidate duplicate definitions
WalkthroughsDescription• Add requirement tracing markers to implementations • Consolidate duplicate requirement definitions in documentation • Update requirement documentation with implementation status • Add missing YAML frontmatter to requirements file Diagramflowchart LR
A["Duplicate Requirements<br/>in Documentation"] -->|Consolidate| B["Single Canonical<br/>Definition in ux.md"]
C["Code Implementations"] -->|Add Tracing| D["Link to Requirements<br/>via Comments"]
E["Incomplete Requirements<br/>Metadata"] -->|Update| F["Add Status & Frontmatter"]
File Changes1. jabgui/src/main/java/org/jabref/gui/maintable/OpenUrlAction.java
|
Code Review by Qodo
1. Incorrect banner requirement link
|
* upstream/main: (775 commits) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#15682) Chore(deps): Bump org.glassfish.jaxb:jaxb-runtime in /versions (#15681) Update dependency com.konghq:unirest-modules-gson to v4.9.0 (#15679) Integrate with SearchRxiv (#15373) Fix requirements (#15600) refactor: less objects during writing (#15677) Fix: suppress WARN for empty or blank column name in MainTableColumnModel#parse() (#15576) New Crowdin updates (#15676) Chore(deps): Bump com.github.ben-manes.caffeine:caffeine in /versions (#15673) Fix Nullwarnings - C (Mark bst package as nonnull by default) (#15663) Chore(deps): Bump com.github.javaparser:javaparser-symbol-solver-core (#15674) Chore(deps): Bump com.github.javaparser:javaparser-core in /versions (#15672) New Crowdin updates (#15669) Fix OpenRewrite (#15670) Udpate heylogs (and fix CHANGELOG.md) (#15671) Improve security and prevent shell injection for push2applications (#15628) Fix depdency analysis (#15668) Always use CI-local "gradle", instead of gradlew (#15667) Change OpenRewrite task to use rewriteDryRun (#15664) Add small documentation to parameter (#15666) ...
I think, our requirements are not clean. This fixes some issues.
Steps to test
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)