Fix "Dependency Scopes"#15668
Merged
Merged
Conversation
Contributor
Review Summary by QodoFix dependency scope for ikonli.material module
WalkthroughsDescription• Mark org.kordamp.ikonli.material as runtime dependency • Fixes dependency scope analysis in module-info.java • Prevents incorrect compile-time dependency requirement Diagramflowchart LR
A["module-info.java"] -- "mark as runtime" --> B["org.kordamp.ikonli.material"]
B -- "corrects scope" --> C["Dependency Analysis"]
File Changes1. jabgui/src/main/java/module-info.java
|
Contributor
Code Review by Qodo
1. Undocumented runtime scope marker
|
jabref-machine
approved these changes
May 3, 2026
Siedlerchr
reviewed
May 3, 2026
| requires org.kordamp.ikonli.core; | ||
| requires org.kordamp.ikonli.javafx; | ||
| requires org.kordamp.ikonli.material; | ||
| requires /*runtime*/ org.kordamp.ikonli.material; |
Member
There was a problem hiding this comment.
This looks wrong. Sure this works? Maybe we need this in dependency rules?
Member
There was a problem hiding this comment.
I think the issue is that we don't use it in jabref but requires this as runtime dependency for gemsfx
Member
Author
There was a problem hiding this comment.
I filed gradlex-org/java-module-dependencies#302
TL;DR: gradlex plugin "magic"
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Siedlerchr
added a commit
to FynnianB/jabref
that referenced
this pull request
May 4, 2026
…rity * upstream/main: (204 commits) New Crowdin updates (JabRef#15669) Fix OpenRewrite (JabRef#15670) Udpate heylogs (and fix CHANGELOG.md) (JabRef#15671) Improve security and prevent shell injection for push2applications (JabRef#15628) Fix depdency analysis (JabRef#15668) Always use CI-local "gradle", instead of gradlew (JabRef#15667) Change OpenRewrite task to use rewriteDryRun (JabRef#15664) Add small documentation to parameter (JabRef#15666) Fix markbaseChanged for "imported entries" (JabRef#15610) Add forgotten --fresh chore(deps): update dependency com.github.ben-manes.caffeine:caffeine to v3.2.4 (JabRef#15662) chore(deps): update jackson monorepo to v3.1.3 (JabRef#15659) chore(deps): update dependency org.glassfish.hk2:hk2-utils to v4.0.1 (JabRef#15657) chore(deps): update dependency org.glassfish.hk2:hk2-locator to v4.0.1 (JabRef#15656) fix gemsfx missing icon resolving (JabRef#15655) chore(deps): update dependency org.glassfish.hk2:hk2-api to v4.0.1 (JabRef#15654) chore(deps): update dependency org.postgresql:postgresql to v42.7.11 (JabRef#15634) Chore(deps): Bump tools.jackson:jackson-bom in /versions (JabRef#15653) Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (JabRef#15652) Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (JabRef#15651) ...
Siedlerchr
added a commit
that referenced
this pull request
May 5, 2026
* upstream/main: (775 commits) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#15682) Chore(deps): Bump org.glassfish.jaxb:jaxb-runtime in /versions (#15681) Update dependency com.konghq:unirest-modules-gson to v4.9.0 (#15679) Integrate with SearchRxiv (#15373) Fix requirements (#15600) refactor: less objects during writing (#15677) Fix: suppress WARN for empty or blank column name in MainTableColumnModel#parse() (#15576) New Crowdin updates (#15676) Chore(deps): Bump com.github.ben-manes.caffeine:caffeine in /versions (#15673) Fix Nullwarnings - C (Mark bst package as nonnull by default) (#15663) Chore(deps): Bump com.github.javaparser:javaparser-symbol-solver-core (#15674) Chore(deps): Bump com.github.javaparser:javaparser-core in /versions (#15672) New Crowdin updates (#15669) Fix OpenRewrite (#15670) Udpate heylogs (and fix CHANGELOG.md) (#15671) Improve security and prevent shell injection for push2applications (#15628) Fix depdency analysis (#15668) Always use CI-local "gradle", instead of gradlew (#15667) Change OpenRewrite task to use rewriteDryRun (#15664) Add small documentation to parameter (#15666) ...
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the test "Dependency Scopes"
After this, the check will be mandatory - to prevent slop in main branch w.r.t. dependencies
Steps to test
See CI passing
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)