• Eliminate unnecessary TypedBibEntry object creation during entry writing
• Directly access entry type display name from BibEntry object
• Reduce memory allocation overhead in bibtex writing process

Eliminate TypedBibEntry object creation

• Removed instantiation of TypedBibEntry object in writeEntryType() method
• Replaced with direct call to entry.getType().getDisplayName() for type display
• Maintains identical functionality while reducing object allocation

jablib/src/main/java/org/jabref/logic/bibtex/BibEntryWriter.java

Description

BibEntryWriter.writeEntryType still accepts BibDatabaseMode but no longer uses it after removing
TypedBibEntry, leaving a misleading/dead parameter. This increases maintenance risk because callers
may assume the mode affects how entry types are written when it currently does not.

Code

jablib/src/main/java/org/jabref/logic/bibtex/BibEntryWriter.java[R146-148]

  private void writeEntryType(BibEntry entry, BibWriter out, BibDatabaseMode bibDatabaseMode) throws IOException {
      int start = out.getCurrentPosition();
-        TypedBibEntry typedEntry = new TypedBibEntry(entry, bibDatabaseMode);
-        out.write('@' + typedEntry.getTypeForDisplay());
+        out.write('@' + entry.getType().getDisplayName());

Evidence

writeEntryType still declares bibDatabaseMode but does not reference it in the body, and callers
still pass the mode through. TypedBibEntry#getTypeForDisplay confirms there is no mode-dependent
behavior for type display (it simply delegates to entry.getType().getDisplayName()).

jablib/src/main/java/org/jabref/logic/bibtex/BibEntryWriter.java[96-152]
jablib/src/main/java/org/jabref/logic/bibtex/TypedBibEntry.java[16-56]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`BibEntryWriter#writeEntryType` takes a `BibDatabaseMode bibDatabaseMode` parameter, but after the refactor it is unused.
### Issue Context
`TypedBibEntry#getTypeForDisplay()` already returns `entry.getType().getDisplayName()` and does not use the mode, so keeping `bibDatabaseMode` in `writeEntryType` is now misleading and adds dead API surface.
### Fix Focus Areas
- jablib/src/main/java/org/jabref/logic/bibtex/BibEntryWriter.java[96-152]
### What to change
- Remove the `bibDatabaseMode` parameter from `writeEntryType`.
- Update the call site in `writeRequiredFieldsFirstRemainingFieldsSecond` accordingly.
- Ensure there are no remaining unused imports/parameters after the signature change.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools