[RFC] Deprecation and alternatives for utf8_encode and utf8_decode#1
Closed
[RFC] Deprecation and alternatives for utf8_encode and utf8_decode#1
Conversation
ee09b4f to
b30ad00
Compare
This integrates user note 127480.
So that gen_stub.php --replace-methodsynopses --verify can find them all
To stress the names are not in LC and Core is present. Closes phpGH-1819.
…t accept time zone offsets
We deliberately ignore potential custom SAPIs. This integrates user note 116174.
* add final modifier * add xi:include for constructor * fix interface markup
Closes phpGH-1829.
Using try catch is irrelevant to examples and echoing errors out unconditionally is a bad practice.
When removing the `not()` operator, some closing parentheses have been overlooked, which resulted in broken xpointer expressions.
We fix the wording in the explanation, too.
…#1954) * Add an example showing how two associative arrays are combined * Modernize array syntax in first example, use var_dump over print_r, revise wording, add types of fruits and vegetables into second example * Add `array_merge()` to the "See Also" section
PECL stopped generating DLLs earlier this year. As of ext-mongodb 1.15.0, DLLs are now generated by a GitHub Action and attached to releases. https://jira.mongodb.org/browse/PHPC-2143
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
The big one is the need to clarify the behaviour around the coercive typing mode, as the conversion of objects to strings is relatively straight forward but in theory internal objects that overload the cast handler can convert to other types too. Drive-by typo fix Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Co-authored-by: Anna Filina <afilina@gmail.com> Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de> Co-authored-by: George Peter Banyard <girgias@php.net>
b30ad00 to
dbe2452
Compare
IMSoP
pushed a commit
that referenced
this pull request
Dec 22, 2022
dbe2452 to
8818721
Compare
8818721 to
ee4bcd6
Compare
Owner
Author
|
Re-opened properly: php#2107 |
IMSoP
pushed a commit
that referenced
this pull request
Mar 22, 2025
…hp#3485) * Solr 2.7.0: SolrQuery::setHighlightQuery * Apply suggestions from code review #1 formatting suggestions from CR Co-authored-by: Gina Peter Banyard <girgias@php.net> * SolrQuery::setHighlightQuery: clarification and rewording * SolrQuery: remove entities file * Whitespaces --------- Co-authored-by: Gina Peter Banyard <girgias@php.net>
IMSoP
pushed a commit
that referenced
this pull request
Mar 22, 2025
This makes the example executable. Remove superfluous callable examples. --------- Co-authored-by: Arthur <arthur.tkachenko@giftcardsgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed additional wording if https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode passes
This is a temporary PR to compare against php#1418 which includes improvements which can happen even if deprecation doesn't go ahead.