Skip to content

Use even more &alias; entities#1801

Merged
kocsismate merged 2 commits intophp:masterfrom
kocsismate:alias2
Sep 7, 2022
Merged

Use even more &alias; entities#1801
kocsismate merged 2 commits intophp:masterfrom
kocsismate:alias2

Conversation

@kocsismate
Copy link
Copy Markdown
Member

So that php/php-src#9491 can find all the aliases.

@salathe
Copy link
Copy Markdown
Contributor

salathe commented Sep 7, 2022

A few more to do:

  • reference/solr/solrdocument/reset.xml: <refpurpose>This is an alias to SolrDocument::clear()</refpurpose>
  • reference/solr/solrparams/add.xml: <refpurpose>This is an alias for SolrParams::addParam</refpurpose>
  • reference/solr/solrparams/get.xml: <refpurpose>This is an alias for SolrParams::getParam</refpurpose>

Copy link
Copy Markdown
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Note there are also &info.function.alias; and &info.method.alias; which are used for basically the same purpose. I guess we need to cater to these as well; maybe just replace them with &Alias;?

@kocsismate kocsismate merged commit bc0556b into php:master Sep 7, 2022
@kocsismate kocsismate deleted the alias2 branch September 7, 2022 12:09
@kocsismate
Copy link
Copy Markdown
Member Author

Note there are also &info.function.alias; and &info.method.alias; which are used for basically the same purpose. I guess we need to cater to these as well; maybe just replace them with &Alias;?

Yeah, I saw them, but I didn't touch them because they were luckily not used in the <refpurpose> tag. As these entities use a slightly different wording than &Alias;, I decided not to complicate my PR.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Sep 7, 2022

I didn't touch them because they were luckily not used in the <refpurpose> tag

Indeed. However, there are some case where they are used in the description, but there is no &Alias; in the refpurpuse, e.g. https://github.com/php/doc-en/blob/master/reference/curl/functions/curl-file-create.xml. I assume that needs to fixed.

tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
So that gen_stub.php --replace-methodsynopses --verify can find them all
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
So that gen_stub.php --replace-methodsynopses --verify can find them all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants