Improve documentation of string encoding conversion functions#1418
Merged
cmb69 merged 1 commit intophp:masterfrom Apr 4, 2022
Merged
Improve documentation of string encoding conversion functions#1418cmb69 merged 1 commit intophp:masterfrom
cmb69 merged 1 commit intophp:masterfrom
Conversation
7cd18b3 to
988d617
Compare
cmb69
reviewed
Mar 21, 2022
Member
cmb69
left a comment
There was a problem hiding this comment.
Besides some nits (mostly style related), this looks good to me.
IMSoP
commented
Mar 23, 2022
Collaborator
Author
IMSoP
left a comment
There was a problem hiding this comment.
Thanks for the thorough review! I think I've caught all those bits now.
988d617 to
1db6af7
Compare
- Move utf8_encode and utf8_decode into the strings chapter, since they were moved out of the XML extension in 7.2 - Recommend mb_convert_encoding, iconv, and UConverter::transcode when mentioning encoding in passing - Document UConverter::transcode, based on examination of source and upstream ICU docs - Make the language used more consistent, e.g. "convert" rather than "encode"/"decode", "encoding" rather than "charset"
1db6af7 to
e677270
Compare
Collaborator
Author
Member
|
Thank you very much! |
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
- Move utf8_encode and utf8_decode into the strings chapter, since they were moved out of the XML extension in 7.2 - Recommend mb_convert_encoding, iconv, and UConverter::transcode when mentioning encoding in passing - Document UConverter::transcode, based on examination of source and upstream ICU docs - Make the language used more consistent, e.g. "convert" rather than "encode"/"decode", "encoding" rather than "charset" Closes phpGH-1418.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they were moved out of the XML extension in 7.2
when mentioning encoding in passing
and upstream ICU docs
than "encode"/"decode", "encoding" rather than "charset"