ldap: Document removal of ber_identifier param#2086
Merged
cmb69 merged 1 commit intophp:masterfrom Dec 17, 2022
Merged
Conversation
43d916d to
e2bcd78
Compare
Contributor
Author
|
Okay, that's done. |
Member
|
Thank you! |
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for ldap_first_attribute and ldap_next_attribute note that PHP accepts a third, deprecated argument,
$ber_identifierwithout raising an error.In fact, passing 3 parameters to these functions has been an ArgumentCountError since PHP 8.0.0 (see php/php-src@eeec37d).
For both functions, this change removes the argument from the list, removes the note indicating that a third argument can be passed, and adds the change at version 8.0.0 to the changelog.