Skip to content

Fix #896: InternalIterator is not documented#899

Closed
cmb69 wants to merge 1 commit intophp:masterfrom
cmb69:cmb/internaliterator
Closed

Fix #896: InternalIterator is not documented#899
cmb69 wants to merge 1 commit intophp:masterfrom
cmb69:cmb/internaliterator

Conversation

@cmb69
Copy link
Copy Markdown
Member

@cmb69 cmb69 commented Sep 3, 2021

This is a skeleton for now. Help to actually document the class is welcome!

@thinkverse
Copy link
Copy Markdown
Contributor

For anyone wanting a bit of information about InternalIterator, it was introduced in PR (php/php-src#5216).

From my limited understanding, it's the generic iterator class some PHP classes use internally to represent Traversable objects? For instance, running a WeakMaps getIterator method against an instanceof \InternalIterator returns true, as shown here (3v4l.org/HRpmk). Though I might be off so please, feel free to correct me if I am.

@cmb69
Copy link
Copy Markdown
Member Author

cmb69 commented Sep 14, 2021

@thinkverse, I think you're pretty much right on.

@Girgias
Copy link
Copy Markdown
Member

Girgias commented Sep 13, 2022

Should we just merge this as is, and enhance later?

@cmb69
Copy link
Copy Markdown
Member Author

cmb69 commented Sep 15, 2022

I've fleshed that out a bit.

@cmb69 cmb69 closed this in 2c974ae Sep 15, 2022
@cmb69 cmb69 deleted the cmb/internaliterator branch September 15, 2022 13:28
saundefined pushed a commit to saundefined/doc-en that referenced this pull request Sep 20, 2022
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants