Solr 2.7.0: SolrQuery::setHighlightQuery / getHighlightQuery (hl.q)#3485
Merged
Girgias merged 5 commits intophp:masterfrom Sep 11, 2024
Merged
Solr 2.7.0: SolrQuery::setHighlightQuery / getHighlightQuery (hl.q)#3485Girgias merged 5 commits intophp:masterfrom
Girgias merged 5 commits intophp:masterfrom
Conversation
Contributor
Author
|
@Girgias ping! I wonder why the entities file doesn't exist anymore |
Member
The entities file should be generated by configure, so you shouldn't have it included in the git sources. |
Girgias
requested changes
Jul 7, 2024
Member
Girgias
left a comment
There was a problem hiding this comment.
Sorry for the delay, I was somewhat busy
Comment on lines
+16
to
+18
| <para> | ||
| A query to use for highlighting. This parameter allows you to highlight different terms or fields than those being used to retrieve documents. | ||
| </para> |
Member
There was a problem hiding this comment.
The manual's style guide says to not use personalization (i.e. using "you") could you rephrase the sentence?
Suggested change
| <para> | |
| A query to use for highlighting. This parameter allows you to highlight different terms or fields than those being used to retrieve documents. | |
| </para> | |
| <para> | |
| A query to use for highlighting. | |
| This parameter allows you to highlight different terms or fields than those being used to retrieve documents. | |
| </para> |
Comment on lines
+20
to
+22
| <para>Default: value of q</para> | ||
| <para>SolrParam: hl.q</para> | ||
| </refsect1> |
Member
There was a problem hiding this comment.
I'm confused by those two para tags, what purpose to they serve?
formatting suggestions from CR Co-authored-by: Gina Peter Banyard <girgias@php.net>
Contributor
Author
|
@Girgias sorry took me a while to find this PR for some reason, I thought it was long time merged. Just tag me next time please |
Girgias
approved these changes
Sep 11, 2024
Girgias
reviewed
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added API changes from PECL Solr 2.7.0