Skip to content

Release v1.26.0#2016

Merged
tpdownes merged 117 commits into
mainfrom
release-candidate
Dec 4, 2023
Merged

Release v1.26.0#2016
tpdownes merged 117 commits into
mainfrom
release-candidate

Conversation

@rohitramu

Copy link
Copy Markdown
Collaborator

No description provided.

cdunbar13 and others added 30 commits October 31, 2023 18:08
* Add Path specialization that can be extended with cty.Path;
* Point label validation to offending value;
* Fix panic if label is not a string.

```yaml
...
vars:
  labels:
    good: "clint"
    bad: [1, 2, 3]
    ugly: true
```

```sh
Error: vars.labels must be a map of strings
24:   labels:
```

```
Error: vars.labels must be a map of strings
26:     bad: [1, 2, 3]
        ^
Error: vars.labels must be a map of strings
27:     ugly: true
        ^
```
…s in daily cleanup to prevent them blocking if one fails.
Add name to triggers for vm-instance because that can be specified now
…ance-trigger-fix

Revert "Add name to triggers for vm-instance because that can be specified now"
```
validator "test_module_not_used" failed:
Error: module "compute_node_group" uses module "debug_partition", but matching setting and outputs were not found. This may be because the value is set explicitly or set by a prior used module
63:     use: [debug_partition, debug_node_group, network1]
              ^
Error: module "compute_node_group" uses module "debug_node_group", but matching setting and outputs were not found. This may be because the value is set explicitly or set by a prior used module
63:     use: [debug_partition, debug_node_group, network1]
                               ^
Error: module "compute_node_group" uses module "network1", but matching setting and outputs were not found. This may be because the value is set explicitly or set by a prior used module
63:     use: [debug_partition, debug_node_group, network1]
```
Add Integration test for Slurm V6 TPU nodeset
Bumps [django](https://github.com/django/django) from 4.2.3 to 4.2.7.
- [Commits](django/django@4.2.3...4.2.7)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
* Do not set role-label in expand, rely on module embedded labels;
* Add ghpc labels to packer module.
This commit fixes an issue in the ramble-setup module where the
requirements.txt file was always downloaded from the same repo
(regardless of the repo used for the `git clone` call). As a result, if
a ref was passed that was not available in the main repo, this module
would fail.

After making this change, the ramble and spack template files were
unified more and added to the duplicate-diff tool.
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.148.0 to 0.149.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.148.0...v0.149.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.13.0 to 0.14.0.
- [Commits](golang/sys@v0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Update stockout check to account for logging delay
nick-stroud and others added 23 commits November 13, 2023 15:03
Slurm6. Deprecate `enable_login`, only consider presence of `login_nodes`
Add native support for Google Cloud Storage with GKE
Slurm6. Surface `login_network_storage`
```sh
$ ./ghpc deploy tst
Testing if deployment group tst/primary requires adding or changing cloud infrastructure
Error: terraform plan for deployment group tst/primary failed; run "ghpc export-outputs" on previous deployment groups to define inputs
exit status 1

Error: No value for required variable

  on variables.tf line 32:
  32: variable "region" {

The root module input variable "region" is not set, and has no default value.
Use a -var or -var-file command line argument to provide a value for this
variable.

...

$ ./ghpc deploy tst
Testing if deployment group tst/primary requires adding or changing cloud infrastructure
Error: terraform plan for deployment group tst/primary failed
exit status 1

Error: Invalid value for variable

  on main.tf line 20, in module "network":
  20:   network_address_range = "over the hills and far away"
    ├────────────────
    │ var.network_address_range is "over the hills and far away"

IP address range must be in CIDR format.

This was checked by the validation rule at
modules/embedded/modules/network/vpc/variables.tf:65,3-13.
```
Selectevly suggest to run `ghpc export-outputs`
The `group_name` is very misleading name, as there is no notion of "group".
Instead it's an "unique login node name".
The only reason to have it is to be able to use TF `for_each = { turn list of login_nodes into map node.name_prefix -> node}`

* Rename `group_name -> name`;
* Add validation for uniqueness.
Rename misleading `login group_name -> name`
* Unwrap `slurm_cluster/modules/slurm_controller_instance` into `schedmd-slurm-gcp-v6-controller/controller.tf`;
* Simplify unwrapped `slurm_controller_instance`;
* Set `depends_on=[module.slurm_files,...` for `slurm_controller_instance`;
* Allow setting `var.cloudsql`.
Enable support for CloudSQL
…cement

Forces VMs to be replaced when placement policy is destroyed
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.150.0 to 0.151.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.150.0...v0.151.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…es/develop/google.golang.org/api-0.151.0

Bump google.golang.org/api from 0.150.0 to 0.151.0
The /etc/profile.d login prompt informational message makes the
assumption that the VM is running a startup-script that uses our
startup-script module. This assumption is broken when an image is built
using our startup-script module and then a VM is booted with that image
that does not execute our startup-script module. This assumption is also
broken upon reboots of Slurm VMs because our script is wrapped inside
a startup script solution developed by SchedMD that exits early when
Slurm has previously started successfully. We can reconsider enabling
this message more robustly as part of future work.
…essage

Eliminate startup-script hasn't started message
@tpdownes tpdownes self-requested a review December 4, 2023 14:20
@tpdownes tpdownes self-assigned this Dec 4, 2023
@cdunbar13 cdunbar13 self-requested a review December 4, 2023 14:37
@tpdownes tpdownes merged commit e8a7e20 into main Dec 4, 2023
@tpdownes tpdownes deleted the release-candidate branch December 4, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants