Eliminate startup-script hasn't started message#2001
Merged
tpdownes merged 1 commit intoNov 28, 2023
Merged
Conversation
The /etc/profile.d login prompt informational message makes the assumption that the VM is running a startup-script that uses our startup-script module. This assumption is broken when an image is built using our startup-script module and then a VM is booted with that image that does not execute our startup-script module. This assumption is also broken upon reboots of Slurm VMs because our script is wrapped inside a startup script solution developed by SchedMD that exits early when Slurm has previously started successfully. We can reconsider enabling this message more robustly as part of future work.
Contributor
Author
|
Can reproduce problem for Slurm using examples/image-builder.yaml. Can test behavior on vm-instance using: # Copyright 2022 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
---
blueprint_name: startup-vm-instance
vars:
project_id: ## Set project id here
deployment_name: testfix
region: us-east4
zone: us-east4-c
deployment_groups:
- group: first
modules:
- id: network1
source: modules/network/vpc
- id: script
source: modules/scripts/startup-script
settings:
runners:
- type: shell
destination: tmp.sh
content: |
#!/bin/bash
sleep 180
- id: vm0
source: modules/compute/vm-instance
use:
- network1
- script
settings:
name_prefix: vm0
machine_type: n1-standard-2
- id: vm1
source: modules/compute/vm-instance
use:
- network1
settings:
name_prefix: vm1
machine_type: n1-standard-2 |
rohitramu
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /etc/profile.d login prompt informational message makes the assumption that the VM is running a startup-script that uses our startup-script module. This assumption is broken when an image is built using our startup-script module and then a VM is booted with that image that does not execute our startup-script module. This assumption is also broken upon reboots of Slurm VMs because our script is wrapped inside a startup script solution developed by SchedMD that exits early when Slurm has previously started successfully. We can reconsider enabling this message more robustly as part of future work.
Submission Checklist
Please take the following actions before submitting this pull request.