Slurm6. Enable support for CloudSQL#1945
Merged
Merged
Conversation
tpdownes
suggested changes
Nov 10, 2023
tpdownes
left a comment
Contributor
There was a problem hiding this comment.
- Please make the minimal changes for syntax.
- I'm a little concerned at the presence of the "conditional creation of resource" (anti-)pattern in several places. This is not the only example of it in the Toolkit, but it can make dependency tracking difficult. I'd like to take a moment (myself) to look at the design doc and understand.
- I believe this is capturing all the "cleanup" variables behavior in once place (going by memory, this is part of the design) and that's a good thing!
* Unwrap `slurm_cluster/modules/slurm_controller_instance` into `schedmd-slurm-gcp-v6-controller/controller.tf`; * Simplify unwrapped `slurm_controller_instance`; * Set `depends_on=[module.slurm_files,...` for `slurm_controller_instance`; * Allow setting `var.cloudsql`.
tpdownes
approved these changes
Nov 15, 2023
tpdownes
left a comment
Contributor
There was a problem hiding this comment.
I think the choice to point directly to _slurm_instance is probably reasonable as having a chain of 2 wrappers is not likely to be helping us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slurm_cluster/modules/slurm_controller_instanceintoschedmd-slurm-gcp-v6-controller/controller.tf;slurm_controller_instance;depends_on=[module.slurm_files,...forslurm_controller_instance;var.cloudsql.