Rename misleading login group_name -> name_prefix#1974
Merged
Conversation
nick-stroud
reviewed
Nov 14, 2023
c580b68 to
d76a46c
Compare
login group_name -> namelogin group_name -> name_prefix
d76a46c to
38f00c8
Compare
nick-stroud
approved these changes
Nov 14, 2023
38f00c8 to
b7c86d0
Compare
The `group_name` is very misleading name, as there is no notion of "group".
Instead it's an "unique login node name".
The only reason to have it is to be able to use TF `for_each = { turn list of login_nodes into map node.name_prefix -> node}`
* Rename `group_name -> name`;
* Add validation for uniqueness.
b7c86d0 to
46d5560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
group_nameis misleading name, as there is no notion of "group". Instead it's an "unique login node name".The only reason to have it is to be able to use TF
for_each = { turn list of login_nodes into map node.name_prefix -> node}group_name -> name_prefix;