Update stockout check to account for logging delay#1908
Merged
cdunbar13 merged 3 commits intoNov 6, 2023
Conversation
Collaborator
Author
|
The failure on PR-test-hpc-slurm-chromeremotedesktop shows the fix (so not an actual issue with this PR). |
nick-stroud
requested changes
Nov 1, 2023
nick-stroud
previously approved these changes
Nov 3, 2023
nick-stroud
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a slight delay with logging that means that we won't necessarily see stockout messages immediately after an integration test fails. To account for this, I've adjusted the stockout check to wait until we get some content back in stdout from the logging command. This also required a
failed_when: falseas we're just checking for logs, nothing is actually failing if we don't find any stockout issues.I've also updated the label to be the generated command, so we can debug if any issues come up with the stockout check, in the future.